mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Nishanth Menon <nm@ti.com>,
	linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: reset: Convert the ti,syscon-reset binding to DT schema
Date: Tue, 10 Nov 2026 08:38:21 -0600	[thread overview]
Message-ID: <avMsXdwyw4FsQtZG@p14s> (raw)
In-Reply-To: <20261109173112.4111810-1-robh@kernel.org>

On Mon, Nov 09, 2026 at 11:31:11AM -0600, Rob Herring (Arm) wrote:
> Convert the ti,syscon-reset binding to DT schema format. It's a straight
> forward conversion.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../bindings/remoteproc/ti,keystone-rproc.txt |  2 +-
>  .../bindings/reset/ti,syscon-reset.yaml       | 58 ++++++++++++
>  .../bindings/reset/ti-syscon-reset.txt        | 91 -------------------
>  3 files changed, 59 insertions(+), 92 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/reset/ti,syscon-reset.yaml
>  delete mode 100644 Documentation/devicetree/bindings/reset/ti-syscon-reset.txt

Applied.

Thanks,
Mathieu

> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt b/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt
> index 847552133633..94f4508c8b0c 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt
> @@ -46,7 +46,7 @@ The following are the mandatory properties:
>  			managing the resets for this device, and a reset
>  			specifier. Please refer to either of the following reset
>  			bindings for the reset argument specifier as per SoC,
> -			Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> +			Documentation/devicetree/bindings/reset/ti,syscon-reset.yaml
>  			    for 66AK2HK/66AK2L/66AK2E SoCs or,
>  			Documentation/devicetree/bindings/reset/ti,sci-reset.yaml
>  			    for 66AK2G SoCs
> diff --git a/Documentation/devicetree/bindings/reset/ti,syscon-reset.yaml b/Documentation/devicetree/bindings/reset/ti,syscon-reset.yaml
> new file mode 100644
> index 000000000000..1cbb2bf88716
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/ti,syscon-reset.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/ti,syscon-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI Syscon Reset Controller
> +
> +maintainers:
> +  - Nishanth Menon <nm@ti.com>
> +
> +description:
> +  Reset controller implemented by registers in the parent syscon.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: ti,syscon-reset
> +      - items:
> +          - enum:
> +              - ti,k2e-pscrst
> +              - ti,k2l-pscrst
> +              - ti,k2hk-pscrst
> +          - const: ti,syscon-reset
> +
> +  '#reset-cells':
> +    const: 1
> +
> +  ti,reset-bits:
> +    description: >
> +      Seven cells per reset, indexed by the reset specifier:
> +
> +        Cell #1 : offset of the reset assert control register
> +        Cell #2 : bit position of the reset in the reset assert control register
> +        Cell #3 : offset of the reset deassert control register
> +        Cell #4 : bit position of the reset in the reset deassert control register
> +        Cell #5 : offset of the reset status register
> +        Cell #6 : bit position of the reset in the reset status register
> +        Cell #7 : Flags used to control reset behavior, available flags defined
> +                  in the DT include file <dt-bindings/reset/ti-syscon.h>
> +
> +required:
> +  - compatible
> +  - '#reset-cells'
> +  - ti,reset-bits
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/reset/ti-syscon.h>
> +
> +    reset-controller {
> +        compatible = "ti,k2e-pscrst", "ti,syscon-reset";
> +        #reset-cells = <1>;
> +        ti,reset-bits = <0xa3c 8 0xa3c 8 0x83c 8
> +                          (ASSERT_CLEAR | DEASSERT_SET | STATUS_CLEAR)>;
> +    };
> diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> deleted file mode 100644
> index 61a0ff33e89f..000000000000
> --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> +++ /dev/null
> @@ -1,91 +0,0 @@
> -TI SysCon Reset Controller
> -=======================
> -
> -Almost all SoCs have hardware modules that require reset control in addition
> -to clock and power control for their functionality. The reset control is
> -typically provided by means of memory-mapped I/O registers. These registers are
> -sometimes a part of a larger register space region implementing various
> -functionalities. This register range is best represented as a syscon node to
> -allow multiple entities to access their relevant registers in the common
> -register space.
> -
> -A SysCon Reset Controller node defines a device that uses a syscon node
> -and provides reset management functionality for various hardware modules
> -present on the SoC.
> -
> -SysCon Reset Controller Node
> -============================
> -Each of the reset provider/controller nodes should be a child of a syscon
> -node and have the following properties.
> -
> -Required properties:
> ---------------------
> - - compatible		: Should be,
> -			    "ti,k2e-pscrst"
> -			    "ti,k2l-pscrst"
> -			    "ti,k2hk-pscrst"
> -			    "ti,syscon-reset"
> - - #reset-cells		: Should be 1. Please see the reset consumer node below
> -			  for usage details
> - - ti,reset-bits	: Contains the reset control register information
> -			  Should contain 7 cells for each reset exposed to
> -			  consumers, defined as:
> -			    Cell #1 : offset of the reset assert control
> -			              register from the syscon register base
> -			    Cell #2 : bit position of the reset in the reset
> -			              assert control register
> -			    Cell #3 : offset of the reset deassert control
> -			              register from the syscon register base
> -			    Cell #4 : bit position of the reset in the reset
> -			              deassert control register
> -			    Cell #5 : offset of the reset status register
> -			              from the syscon register base
> -			    Cell #6 : bit position of the reset in the
> -			              reset status register
> -			    Cell #7 : Flags used to control reset behavior,
> -			              available flags defined in the DT include
> -			              file <dt-bindings/reset/ti-syscon.h>
> -
> -SysCon Reset Consumer Nodes
> -===========================
> -Each of the reset consumer nodes should have the following properties,
> -in addition to their own properties.
> -
> -Required properties:
> ---------------------
> - - resets	: A phandle to the reset controller node and an index number
> -		  to a reset specifier as defined above.
> -
> -Please also refer to Documentation/devicetree/bindings/reset/reset.txt for
> -common reset controller usage by consumers.
> -
> -Example:
> ---------
> -The following example demonstrates a syscon node, the reset controller node
> -using the syscon node, and a consumer (a DSP device) on the TI Keystone 2
> -66AK2E SoC.
> -
> -/ {
> -	soc {
> -		psc: power-sleep-controller@2350000 {
> -			compatible = "syscon", "simple-mfd";
> -			reg = <0x02350000 0x1000>;
> -
> -			pscrst: reset-controller {
> -				compatible = "ti,k2e-pscrst", "ti,syscon-reset";
> -				#reset-cells = <1>;
> -
> -				ti,reset-bits = <
> -					0xa3c 8 0xa3c 8 0x83c 8 (ASSERT_CLEAR | DEASSERT_SET   | STATUS_CLEAR) /* 0: dsp0 */
> -					0xa40 5 0xa44 3 0     0 (ASSERT_SET   | DEASSERT_CLEAR | STATUS_NONE)  /* 1: example */
> -				>;
> -			};
> -		};
> -
> -		dsp0: dsp0 {
> -			...
> -			resets = <&pscrst 0>;
> -			...
> -		};
> -	};
> -};
> -- 
> 2.53.0
> 

      reply	other threads:[~2026-11-10 14:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 17:31 Rob Herring (Arm)
2026-11-10 14:38 ` Mathieu Poirier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avMsXdwyw4FsQtZG@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®