mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yury Norov <ynorov@nvidia.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Kees Cook" <kees@kernel.org>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Yury Norov" <yury.norov@gmail.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	jorge.lopez2@hp.com, hansg@kernel.org,
	"Muhammad Bilal" <meatuni001@gmail.com>,
	platform-driver-x86@vger.kernel.org,
	"Armin Wolf" <W_Armin@gmx.de>
Subject: Re: [PATCH v1 1/1] string: Export strnchrnul()
Date: Tue, 10 Nov 2026 13:01:35 -0500	[thread overview]
Message-ID: <avNb_7QmpPkxa8xq@yury> (raw)
In-Reply-To: <20261110164222.698745-1-andriy.shevchenko@linux.intel.com>

On Tue, Nov 10, 2026 at 05:41:50PM +0100, Andy Shevchenko wrote:
> Export strnchrnul() for users that may be compiled as modules.
> 
> Reported-by: Armin Wolf <W_Armin@gmx.de>
> Closes: https://lore.kernel.org/r/1969fb5a-38ef-4b4b-9d2f-cb9a4348b968@gmx.de
> Fixes: 0bee0cece2a6 ("lib/string: add strnchrnul()")

Not sure that exporting a symbol is actually a fix. It rather looks
like a normal development. Also, I'd like to have this patch attached
to the PDx86 or whatever series that uses it.

Their implementation may change, so this would become the exported
symbols space bloat.

Thanks,
Yury

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> 
> Assumed to go via PDx86 where the first (wow!) module user wants to use it.
> 
>  lib/string.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/string.c b/lib/string.c
> index a3778d5aab4a..cc8982a93afc 100644
> --- a/lib/string.c
> +++ b/lib/string.c
> @@ -352,6 +352,7 @@ char *strnchrnul(const char *s, size_t count, int c)
>  		s++;
>  	return (char *)s;
>  }
> +EXPORT_SYMBOL(strnchrnul);
>  
>  #ifndef __HAVE_ARCH_STRRCHR
>  /**
> -- 
> 2.50.1
> 

  parent reply	other threads:[~2026-11-10 18:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 16:41 Andy Shevchenko
2026-11-10 16:49 ` Andy Shevchenko
2026-11-10 16:55 ` Armin Wolf
2026-11-10 18:01 ` Yury Norov [this message]
2026-11-10 18:39   ` Ilpo Järvinen
2026-11-10 18:42     ` Yury Norov
2026-11-10 18:29 ` Ilpo Järvinen
2026-11-10 19:34   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avNb_7QmpPkxa8xq@yury \
    --to=ynorov@nvidia.com \
    --cc=W_Armin@gmx.de \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jorge.lopez2@hp.com \
    --cc=kees@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=meatuni001@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®