From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-hardening@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>, Kees Cook <kees@kernel.org>,
Andy Shevchenko <andy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Yury Norov <yury.norov@gmail.com>,
jorge.lopez2@hp.com, Hans de Goede <hansg@kernel.org>,
Muhammad Bilal <meatuni001@gmail.com>,
platform-driver-x86@vger.kernel.org, Armin Wolf <W_Armin@gmx.de>
Subject: Re: [PATCH v1 1/1] string: Export strnchrnul()
Date: Tue, 10 Nov 2026 21:34:49 +0200 [thread overview]
Message-ID: <avNx2RwiaCQMkw1S@ashevche-desk.local> (raw)
In-Reply-To: <cec3aee0-a075-bec2-b487-2e28991f2d23@linux.intel.com>
On Tue, Nov 10, 2026 at 08:29:58PM +0200, Ilpo Järvinen wrote:
> On Tue, 10 Nov 2026, Andy Shevchenko wrote:
>
> > Export strnchrnul() for users that may be compiled as modules.
> >
> > Reported-by: Armin Wolf <W_Armin@gmx.de>
> > Closes: https://lore.kernel.org/r/1969fb5a-38ef-4b4b-9d2f-cb9a4348b968@gmx.de
> > Fixes: 0bee0cece2a6 ("lib/string: add strnchrnul()")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >
> > Assumed to go via PDx86 where the first (wow!) module user wants to use it.
>
> Thanks guys,
>
> I'm so surprised by this, sashiko did warn about this so I even checked
> myself and saw an export after the closing brace so thought sashiko was
> just wrong... Maybe I was looking that the strrchr's export, can't think
> of anything else to explain it.
The strchrnul is exported, I believe you missed 'n' which may explain the
course of what happened. Compare:
EXPORT_SYMBOL(strchrnul);
EXPORT_SYMBOL(strnchrnul);
If you don't stare on this, you won't notice the difference at a glance.
(I caught myself on the same, but it was after this report, so I spend
a few more seconds to get it.)
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-11-10 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 16:41 Andy Shevchenko
2026-11-10 16:49 ` Andy Shevchenko
2026-11-10 16:55 ` Armin Wolf
2026-11-10 18:01 ` Yury Norov
2026-11-10 18:39 ` Ilpo Järvinen
2026-11-10 18:42 ` Yury Norov
2026-11-10 18:29 ` Ilpo Järvinen
2026-11-10 19:34 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avNx2RwiaCQMkw1S@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=W_Armin@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jorge.lopez2@hp.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meatuni001@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®