From: Sean Christopherson <seanjc@google.com>
To: Ackerley Tng <ackerleytng@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Sagi Shahar <sagis@google.com>, Lisa Wang <wyihan@google.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Binbin Wu <binbin.wu@linux.intel.com>
Subject: Re: [PATCH v16.1] KVM: selftests: Add support for TDX ucalls, via TDVMCALL_REPORT_FATAL_ERROR
Date: Tue, 10 Nov 2026 10:53:03 -0800 [thread overview]
Message-ID: <avNoDzycqd3PN9gE@seanjc-mac.roam.internal> (raw)
In-Reply-To: <CAEvNRgGHUL4-KSMCsOHznKK3fpvwh=D-H7OwSaqk2A2T0nL6ww@mail.gmail.com>
On Mon, Nov 09, 2026, Ackerley Tng wrote:
> Sean Christopherson <seanjc@google.com> writes:
>
> >
> > [...snip...]
> >
> > diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx.h b/tools/testing/selftests/kvm/include/x86/tdx/tdx.h
> > index d41a1efc8a63..9982aaaba885 100644
> > --- a/tools/testing/selftests/kvm/include/x86/tdx/tdx.h
> > +++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx.h
> > @@ -4,6 +4,13 @@
> >
> > #include <linux/types.h>
> >
> > +/* TDX hypercall Leaf IDs */
> > +#define TDVMCALL_GET_TD_VM_CALL_INFO 0x10000
> > +#define TDVMCALL_MAP_GPA 0x10001
> > +#define TDVMCALL_GET_QUOTE 0x10002
> > +#define TDVMCALL_REPORT_FATAL_ERROR 0x10003
> > +#define TDVMCALL_SETUP_EVENT_NOTIFY_INTERRUPT 0x10004
> > +
>
> No objection, just surprised you'd add all the others that aren't used
> in this patch.
It's nice to have, e.g. provides additional context to help understand what types
of things TDVMCALL does "natively. And I almost always do lookups for things like
this and MSR indices using kernel headers, e.g. versus trying to hunt through a
PDF (assuming I even have or know the "right" PDF).
next prev parent reply other threads:[~2026-11-10 18:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 23:46 [PATCH v16 00/20] TDX KVM selftests Lisa Wang
2026-11-05 23:46 ` [PATCH v16 01/20] KVM: selftests: Add macros to simplify creating VM shapes for non-default types Lisa Wang
2026-11-05 23:46 ` [PATCH v16 02/20] KVM: selftests: Update kvm_init_vm_address_properties() for TDX Lisa Wang
2026-11-09 16:00 ` Ackerley Tng
2026-11-05 23:46 ` [PATCH v16 03/20] KVM: selftests: Initialize the TDX VM Lisa Wang
2026-11-09 5:58 ` Binbin Wu
2026-11-09 19:36 ` Ackerley Tng
2026-11-10 18:57 ` Sean Christopherson
2026-11-05 23:46 ` [PATCH v16 04/20] KVM: selftests: Expose segment definitions to assembly files Lisa Wang
2026-11-05 23:46 ` [PATCH v16 05/20] tools: include: Add kbuild.h for assembly structure offsets Lisa Wang
2026-11-05 23:46 ` [PATCH v16 06/20] KVM: selftests: Introduce structures for TDX guest boot parameters Lisa Wang
2026-11-05 23:46 ` [PATCH v16 07/20] KVM: selftests: Add TDX boot code Lisa Wang
2026-11-05 23:46 ` [PATCH v16 08/20] KVM: selftests: Expose functions to get default sregs values Lisa Wang
2026-11-09 19:40 ` Ackerley Tng
2026-11-05 23:46 ` [PATCH v16 09/20] KVM: selftests: Set up TDX boot code region Lisa Wang
2026-11-09 19:55 ` Ackerley Tng
2026-11-05 23:46 ` [PATCH v16 10/20] KVM: selftests: Set up TDX boot parameters region Lisa Wang
2026-11-05 23:46 ` [PATCH v16 11/20] KVM: selftests: Require guest_memfd for TDX VMs Lisa Wang
2026-11-09 19:56 ` Ackerley Tng
2026-11-05 23:46 ` [PATCH v16 12/20] KVM: selftests: Call KVM_TDX_INIT_VCPU when creating a new TDX vcpu Lisa Wang
2026-11-09 9:11 ` Binbin Wu
2026-11-09 19:59 ` Ackerley Tng
2026-11-05 23:46 ` [PATCH v16 13/20] KVM: selftests: Load per-vCPU guest stack in TDX boot parameters Lisa Wang
2026-11-05 23:46 ` [PATCH v16 14/20] KVM: selftests: Set entry point for TDX guest code Lisa Wang
2026-11-09 20:01 ` Ackerley Tng
2026-11-05 23:46 ` [PATCH v16 15/20] KVM: selftests: Add helpers to init TDX memory and finalize VM Lisa Wang
2026-11-05 23:47 ` [PATCH v16 16/20] KVM: selftests: Load private memory and finalize TDX VM in kvm_arch_vm_finalize_vcpus() Lisa Wang
2026-11-09 20:02 ` Ackerley Tng
2026-11-05 23:47 ` [PATCH v16 17/20] KVM: selftests: Add a helper to issue TDVMCALLs from the TDX vm Lisa Wang
2026-11-05 23:47 ` [PATCH v16 18/20] KVM: selftests: Add support for per-VM ucall ops on x86 Lisa Wang
2026-11-06 16:47 ` [PATCH v16.1] KVM: selftests: Add support for TDX ucalls, via TDVMCALL_REPORT_FATAL_ERROR Sean Christopherson
2026-11-09 8:53 ` Binbin Wu
2026-11-09 16:55 ` Sagi Shahar
2026-11-09 20:16 ` Ackerley Tng
2026-11-10 18:53 ` Sean Christopherson [this message]
2026-11-05 23:47 ` [PATCH v16 19/20] " Lisa Wang
2026-11-05 23:47 ` [PATCH v16 20/20] KVM: selftests: Add TDX lifecycle test Lisa Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avNoDzycqd3PN9gE@seanjc-mac.roam.internal \
--to=seanjc@google.com \
--cc=ackerleytng@google.com \
--cc=binbin.wu@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sagis@google.com \
--cc=wyihan@google.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®