[PATCH v1] parport_pc: Drop unused assignment of pnp_device_id driver data

[PATCH v1] parport_pc: Drop unused assignment of pnp_device_id driver data

[Uwe Kleine-König (The Capable Hub)]

The driver explicitly sets the .driver_data member of struct
pnp_device_id to zero without relying on that value. Drop this unused
assignment.

This patch doesn't modify the compiled array, tested on x86 and arm64.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
Hello,

I'm currently working on a changing various *_device_id definitions.
This patch is irrelevant for this quest and a pure style update for
consistency reasons without further dependencies on it.

So if you don't like this patch, I won't insist.

Best regards
Uwe

 drivers/parport/parport_pc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
index bccfe75fe6e5..7182f68e9228 100644
--- a/drivers/parport/parport_pc.c
+++ b/drivers/parport/parport_pc.c
@@ -3002,9 +3002,9 @@ static int __init parport_pc_init_superio(int autoirq, int autodma)
 
 static const struct pnp_device_id parport_pc_pnp_tbl[] = {
 	/* Standard LPT Printer Port */
-	{.id = "PNP0400", .driver_data = 0},
+	{ .id = "PNP0400" },
 	/* ECP Printer Port */
-	{.id = "PNP0401", .driver_data = 0},
+	{ .id = "PNP0401" },
 	{ }
 };
 

base-commit: 49e02880ec0a8c378e811bc9d85da188d7c6204c
-- 
2.47.3

Re: [PATCH v1] parport_pc: Drop unused assignment of pnp_device_id driver data

[Uwe Kleine-König (The Capable Hub)]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

Hello,

On Wed, Jun 10, 2026 at 04:25:10PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The driver explicitly sets the .driver_data member of struct
> pnp_device_id to zero without relying on that value. Drop this unused
> assignment.
> 
> This patch doesn't modify the compiled array, tested on x86 and arm64.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> Hello,
> 
> I'm currently working on a changing various *_device_id definitions.
> This patch is irrelevant for this quest and a pure style update for
> consistency reasons without further dependencies on it.
> 
> So if you don't like this patch, I won't insist.

However if you just ignore it, I will remind about it anyhow. Is this
still on your radar?

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]