mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] audit: add missing syscalls to signal class
@ 2026-11-11 11:01 Jeffrey Bencteux
  2026-11-11 11:18 ` Arnd Bergmann
  0 siblings, 1 reply; 4+ messages in thread
From: Jeffrey Bencteux @ 2026-11-11 11:01 UTC (permalink / raw)
  To: paul, eparis, arnd, audit; +Cc: linux-arch, linux-kernel, jeff

The pidfd_send_signal(), rt_sigqueueinfo() and rt_tgsigqueueinfo()
system calls are missing from the AUDIT_CLASS_SIGNAL* class. It seems
to be used only in kernel/auditfilter.c to increment the audit_signals
counter.

This counter is used to determine if information related to a target
process of a syscall audit rule using signals, such as its pid,
should be logged (e54dc2431d740a79a6bd013babade99d71b1714f).

Information related to signals sent via these system calls are
currently not correctly logged. The current patch adds it to the
AUDIT_CLASS_SIGNAL* class.

Signed-off-by: Jeffrey Bencteux <jeff@bencteux.fr>
---
 include/asm-generic/audit_signal.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/include/asm-generic/audit_signal.h b/include/asm-generic/audit_signal.h
index 6feab7f18a53..65336a9aef7b 100644
--- a/include/asm-generic/audit_signal.h
+++ b/include/asm-generic/audit_signal.h
@@ -1,3 +1,12 @@
 __NR_kill,
 __NR_tgkill,
 __NR_tkill,
+#ifdef __NR_rt_sigqueueinfo
+__NR_rt_sigqueueinfo,
+#endif
+#ifdef __NR_rt_tgsigqueueinfo
+__NR_rt_tgsigqueueinfo,
+#endif
+#ifdef __NR_pidfd_send_signal
+__NR_pidfd_send_signal,
+#endif

base-commit: 6614d4c05c7a661a925b3d8dbf9c70faac3bd2da
-- 
2.56.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] audit: add missing syscalls to signal class
  2026-11-11 11:01 [PATCH] audit: add missing syscalls to signal class Jeffrey Bencteux
@ 2026-11-11 11:18 ` Arnd Bergmann
  2026-11-11 13:52   ` Jeffrey Bencteux
  0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2026-11-11 11:18 UTC (permalink / raw)
  To: Jeffrey Bencteux, Paul Moore, Eric Paris, audit; +Cc: Linux-Arch, linux-kernel

On Wed, Nov 11, 2026, at 12:01, Jeffrey Bencteux wrote:
> diff --git a/include/asm-generic/audit_signal.h 
> b/include/asm-generic/audit_signal.h
> index 6feab7f18a53..65336a9aef7b 100644
> --- a/include/asm-generic/audit_signal.h
> +++ b/include/asm-generic/audit_signal.h
> @@ -1,3 +1,12 @@
>  __NR_kill,
>  __NR_tgkill,
>  __NR_tkill,
> +#ifdef __NR_rt_sigqueueinfo
> +__NR_rt_sigqueueinfo,
> +#endif
> +#ifdef __NR_rt_tgsigqueueinfo
> +__NR_rt_tgsigqueueinfo,
> +#endif
> +#ifdef __NR_pidfd_send_signal
> +__NR_pidfd_send_signal,
> +#endif

Why the #ifdef checks? These should be available on all architectures.

     Arnd

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] audit: add missing syscalls to signal class
  2026-11-11 11:18 ` Arnd Bergmann
@ 2026-11-11 13:52   ` Jeffrey Bencteux
  2026-11-11 14:23     ` Arnd Bergmann
  0 siblings, 1 reply; 4+ messages in thread
From: Jeffrey Bencteux @ 2026-11-11 13:52 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: Paul Moore, Eric Paris, audit, Linux-Arch, linux-kernel

On Wed, Nov 11, 2026 at 12:18:01PM +0100, Arnd Bergmann wrote:
> Why the #ifdef checks? These should be available on all architectures.

I included them as convention, should they be removed?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] audit: add missing syscalls to signal class
  2026-11-11 13:52   ` Jeffrey Bencteux
@ 2026-11-11 14:23     ` Arnd Bergmann
  0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2026-11-11 14:23 UTC (permalink / raw)
  To: Jeffrey Bencteux; +Cc: Paul Moore, Eric Paris, audit, Linux-Arch, linux-kernel

On Wed, Nov 11, 2026, at 14:52, Jeffrey Bencteux wrote:
> On Wed, Nov 11, 2026 at 12:18:01PM +0100, Arnd Bergmann wrote:
>> Why the #ifdef checks? These should be available on all architectures.
>
> I included them as convention, should they be removed?

Not sure where the convention comes from, it just seemed
odd that you have the #ifdef checks for the newly added
entries but not the ones that are already in this file.

I had not checked the other files that have similar ones.

     Arnd

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-11 14:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-11 11:01 [PATCH] audit: add missing syscalls to signal class Jeffrey Bencteux
2026-11-11 11:18 ` Arnd Bergmann
2026-11-11 13:52   ` Jeffrey Bencteux
2026-11-11 14:23     ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®