From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Chaosheng Qu <quchaosheng000406@163.com>
Cc: netdev-bot+sashiko@kernel.org,
Robin van der Gracht <robin@protonic.nl>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Marc Kleine-Budde <mkl@pengutronix.de>,
kernel@pengutronix.de, linux-can@vger.kernel.org,
linux-kernel@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net v7 3/4] can: j1939: drop the message when the reassembled skb is gone
Date: Fri, 13 Nov 2026 08:25:57 +0100 [thread overview]
Message-ID: <ava7hRQ7lxXckkPL@pengutronix.de> (raw)
In-Reply-To: <179453947398.30993.12910253526180673543@163.com>
On Fri, Nov 13, 2026 at 11:11:13AM +0800, Chaosheng Qu wrote:
> Hi,
>
> Both accepted.
>
> Dropping the message silently is the weak part. session->err stays 0, so
> j1939_session_destroy() queues nothing, and the only trace is a netdev_dbg()
> that is off by default. For an RTS/CTS receive session this runs when the
> receiver's own EOMA comes back, after the originator has already been told
> the message was delivered, so the two sides end up disagreeing with nothing
> in the log. The next version uses WARN_ON_ONCE(!se_skb) and sets
> session->err = -EBADMSG before dropping.
Hm... will a stack trace provide an additional value in this case? If
not, please use netdev_err_once()
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2026-11-13 7:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 1:34 [PATCH net v7 0/4] can: j1939: fix the abort timer and bound EDPO Chaosheng Qu
2026-11-08 1:34 ` [PATCH net v7 1/4] can: j1939: arm the abort timer under the session list lock Chaosheng Qu
2026-11-12 21:49 ` netdev-bot+sashiko
2026-11-13 3:11 ` Chaosheng Qu
2026-11-08 1:34 ` [PATCH net v7 3/4] can: j1939: drop the message when the reassembled skb is gone Chaosheng Qu
2026-11-12 21:49 ` netdev-bot+sashiko
2026-11-13 3:11 ` Chaosheng Qu
2026-11-13 7:25 ` Oleksij Rempel [this message]
2026-11-08 1:34 ` [PATCH net v7 2/4] can: j1939: validate the EDPO packet number Chaosheng Qu
2026-11-12 21:49 ` netdev-bot+sashiko
2026-11-13 3:11 ` Chaosheng Qu
2026-11-08 1:34 ` [PATCH net v7 4/4] can: j1939: reject a CTS that names more packets than the message has Chaosheng Qu
2026-11-12 21:49 ` netdev-bot+sashiko
2026-11-13 3:11 ` Chaosheng Qu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ava7hRQ7lxXckkPL@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev-bot+sashiko@kernel.org \
--cc=quchaosheng000406@163.com \
--cc=robin@protonic.nl \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®