Re: [PATCH 2/7] dmaengine: fsldma: drain channel tasklet during removal

[Frank Li <Frank.li@oss.nxp.com>]

On Sun, Oct 18, 2026 at 12:07:18PM +0800, Jiale Yao wrote:
> The channel IRQ schedules a tasklet that accesses the channel descriptor
> lists. Device removal frees the IRQs and then releases each channel
> without draining tasklets that were already queued.
>
> Kill each channel tasklet before unmapping and freeing the channel. The
> removal path has already freed all controller or channel IRQs, so no
> interrupt handler can queue the tasklet again.
>
> Fixes: 173acc7ce853 ("dmaengine: add driver for Freescale MPC85xx DMA controller")
> Signed-off-by: Jiale Yao <yaojiale02@163.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/fsldma.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
> index 22d62d958abd..0e2f84862261 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -1205,6 +1205,7 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev,
>
>  static void fsl_dma_chan_remove(struct fsldma_chan *chan)
>  {
> +	tasklet_kill(&chan->tasklet);
>  	irq_dispose_mapping(chan->irq);
>  	list_del(&chan->common.device_node);
>  	iounmap(chan->regs);
> --
> 2.34.1
>