From: Frank Li <Frank.li@oss.nxp.com>
To: Jiale Yao <yaojiale02@163.com>
Cc: Linus Walleij <linusw@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Frank Li <Frank.Li@kernel.org>, Dan Williams <djbw@kernel.org>,
Srinidh Kasagar <srinidhi.kasagar@stericsson.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] dmaengine: ste_dma40: synchronize tasklet when releasing a channel
Date: Fri, 13 Nov 2026 15:41:34 -0500 [thread overview]
Message-ID: <avd1_vOb2nvY1qRc@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20261018040724.534641-8-yaojiale02@163.com>
On Sun, Oct 18, 2026 at 12:07:23PM +0800, Jiale Yao wrote:
> DMA completion handling schedules a per-channel tasklet that processes
> completed descriptors and invokes client callbacks. Channel release
> terminates and frees the descriptor state without draining a tasklet
> that was already queued.
>
> After d40_free_dma() removes the channel from the interrupt lookup
> tables, kill the tasklet before returning the channel to the DMAengine
> core.
>
> Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3")
> Signed-off-by: Jiale Yao <yaojiale02@163.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/dma/ste_dma40.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> index 0d9ffa3e2663..647a265590c2 100644
> --- a/drivers/dma/ste_dma40.c
> +++ b/drivers/dma/ste_dma40.c
> @@ -2484,6 +2484,8 @@ static void d40_free_chan_resources(struct dma_chan *chan)
> if (err)
> chan_err(d40c, "Failed to free channel\n");
> spin_unlock_irqrestore(&d40c->lock, flags);
> +
> + tasklet_kill(&d40c->tasklet);
> }
>
> static struct dma_async_tx_descriptor *d40_prep_memcpy(struct dma_chan *chan,
> --
> 2.34.1
>
next prev parent reply other threads:[~2026-11-13 20:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 4:07 [PATCH 0/7] dmaengine: drain completion tasklets during teardown Jiale Yao
2026-10-18 4:07 ` [PATCH 1/7] dmaengine: ep93xx: drain tasklet before freeing channel resources Jiale Yao
2026-11-13 20:37 ` Frank Li
2026-10-18 4:07 ` [PATCH 2/7] dmaengine: fsldma: drain channel tasklet during removal Jiale Yao
2026-11-13 20:38 ` Frank Li
2026-10-18 4:07 ` [PATCH 3/7] dmaengine: mmp_pdma: drain channel tasklets " Jiale Yao
2026-11-13 20:38 ` Frank Li
2026-10-18 4:07 ` [PATCH 4/7] dmaengine: mmp_tdma: synchronize tasklet when freeing a channel Jiale Yao
2026-10-18 4:07 ` [PATCH 5/7] dmaengine: mv_xor: drain IRQ tasklet before freeing channel memory Jiale Yao
2026-11-13 20:40 ` Frank Li
2026-10-18 4:07 ` [PATCH 6/7] dmaengine: mxs-dma: synchronize tasklet when freeing a channel Jiale Yao
2026-11-13 20:41 ` Frank Li
2026-10-18 4:07 ` [PATCH 7/7] dmaengine: ste_dma40: synchronize tasklet when releasing " Jiale Yao
2026-10-18 21:00 ` Linus Walleij
2026-11-13 20:41 ` Frank Li [this message]
2026-10-20 7:36 ` [PATCH 0/7] dmaengine: drain completion tasklets during teardown Peng Fan (OSS)
2026-10-20 8:10 ` jiale yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avd1_vOb2nvY1qRc@lizhi-Precision-Tower-5810 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=djbw@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinidhi.kasagar@stericsson.com \
--cc=vkoul@kernel.org \
--cc=yaojiale02@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®