* [PATCH] powerpc32/bpf: return false from bpf_jit_supports_fsession() on ppc32
@ 2026-10-03 18:42 Karl Mehltretter
2026-11-14 9:27 ` Karl Mehltretter
0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-10-03 18:42 UTC (permalink / raw)
To: Hari Bathini, Christophe Leroy (CS GROUP), Madhavan Srinivasan
Cc: Karl Mehltretter, Naveen N Rao, Michael Ellerman,
Nicholas Piggin, Abhishek Dubey, Dan Carpenter,
Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf,
linuxppc-dev, linux-kernel, kernel test robot
bpf_jit_supports_fsession() returns bool. Commit 92258b5bf1ec
("powerpc32/bpf: Add fsession support") made it return -EOPNOTSUPP on
ppc32 until fsession is validated there. The negative value converts to
true, so the verifier does not reject fsession programs on ppc32. Such a
program loads, and only attaching it fails because
__arch_prepare_bpf_trampoline() returns -EOPNOTSUPP on ppc32.
Return false instead. The load then fails with "JIT does not support
fsession". Tested with a ppc32 kernel on QEMU g3beige.
Fixes: 92258b5bf1ec ("powerpc32/bpf: Add fsession support")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202608010958.cYfBCQAC-lkp@intel.com/
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
arch/powerpc/net/bpf_jit_comp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/net/bpf_jit_comp.c b/arch/powerpc/net/bpf_jit_comp.c
index 7a612688e7a2..64e70f3226b2 100644
--- a/arch/powerpc/net/bpf_jit_comp.c
+++ b/arch/powerpc/net/bpf_jit_comp.c
@@ -539,7 +539,7 @@ bool bpf_jit_supports_fsession(void)
* for fsession and trampoline on ppc32.
*/
if (IS_ENABLED(CONFIG_PPC32))
- return -EOPNOTSUPP;
+ return false;
return true;
}
base-commit: e767a4ea70a3992c37ed604157d32f0dfbf9b1e3
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc32/bpf: return false from bpf_jit_supports_fsession() on ppc32
2026-10-03 18:42 [PATCH] powerpc32/bpf: return false from bpf_jit_supports_fsession() on ppc32 Karl Mehltretter
@ 2026-11-14 9:27 ` Karl Mehltretter
0 siblings, 0 replies; 2+ messages in thread
From: Karl Mehltretter @ 2026-11-14 9:27 UTC (permalink / raw)
To: Hari Bathini, Christophe Leroy (CS GROUP), Madhavan Srinivasan
Cc: Naveen N Rao, Michael Ellerman, Nicholas Piggin, Abhishek Dubey,
Dan Carpenter, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, bpf, linuxppc-dev, linux-kernel,
kernel test robot
On Sat, Oct 03, 2026 at 08:42:26PM +0100, Karl Mehltretter wrote:
> bpf_jit_supports_fsession() returns bool. Commit 92258b5bf1ec
> ("powerpc32/bpf: Add fsession support") made it return -EOPNOTSUPP on
> ppc32 until fsession is validated there. The negative value converts to
> true, so the verifier does not reject fsession programs on ppc32. Such a
> program loads, and only attaching it fails because
> __arch_prepare_bpf_trampoline() returns -EOPNOTSUPP on ppc32.
>
> Return false instead. The load then fails with "JIT does not support
> fsession". Tested with a ppc32 kernel on QEMU g3beige.
>
> Fixes: 92258b5bf1ec ("powerpc32/bpf: Add fsession support")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202608010958.cYfBCQAC-lkp@intel.com/
A friendly ping on this ppc32 BPF fsession fix. Patchwork on netdevbpf
marks it awaiting-upstream for the powerpc tree. Is anything else needed
from my side?
Thanks,
Karl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-14 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-03 18:42 [PATCH] powerpc32/bpf: return false from bpf_jit_supports_fsession() on ppc32 Karl Mehltretter
2026-11-14 9:27 ` Karl Mehltretter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®