Re: [PATCH 2/2] remoteproc: k3-m4: Leave crash recovery enabled

[Francesco Valla <francesco@valla.it>]

Hi Chrispine,

On Mon, Nov 09, 2026 at 08:48:30AM +0300, Chrispine Tinega wrote:
> The M4 driver disables recovery, but nothing reported a crash to the
> remoteproc core, so there was nothing to recover from. Now that
> RP_MBOX_CRASH reaches rproc_report_crash(), recovery resets the M4F and
> boots its firmware again, while Linux keeps running. The stop is a
> plain reset, so it does not need the crashed core's cooperation.
> 

This can be fine for a core started by Linux, but it's not for a core
working in IPC-only mode, where Linux only attaches. In that case, a
recovery action might start a firware living on the Linux userspace that
is different from the one originally started outside of it (and if this
is enabled by default, the user might not even notice this).

> Leave recovery enabled by default. Userspace can still disable it
> through /sys/class/remoteproc/remoteprocN/recovery.
> 
> Signed-off-by: Chrispine Tinega <dev@chrispinetinega.com>
> ---
>  drivers/remoteproc/ti_k3_m4_remoteproc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/ti_k3_m4_remoteproc.c b/drivers/remoteproc/ti_k3_m4_remoteproc.c
> index 4c46f4a25..fbd2b7c04 100644
> --- a/drivers/remoteproc/ti_k3_m4_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_m4_remoteproc.c
> @@ -56,7 +56,6 @@ static int k3_m4_rproc_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	rproc->has_iommu = false;
> -	rproc->recovery_disabled = true;
>  	kproc = rproc->priv;
>  	kproc->dev = dev;
>  	kproc->rproc = rproc;
> -- 
> 2.53.0
> 
> 

Regards,
Francesco