mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: "Stuart Hayes" <stuart.w.hayes@gmail.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Doug Warzecha" <Douglas_Warzecha@dell.com>,
	"Andrew Morton" <akpm@osdl.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] platform/x86: dell: dcdbas: Actually wait for the host control SMI
Date: Mon, 16 Nov 2026 13:17:52 +0200	[thread overview]
Message-ID: <avrmYDgb06et2lj4@ashevche-desk.local> (raw)
In-Reply-To: <c35b26234163789f1fc37ba09a48de58d475629a.1794633178.git.rosenp@gmail.com>

On Fri, Nov 13, 2026 at 10:17:54PM -0800, Rosen Penev wrote:
> For SMI types 2 and 3, host_control_smi() writes the command status as
> -1, raises the SMI and then waits for the BIOS to change the status:
> 
> 	while (apm_cmd->status == ESM_STATUS_CMD_UNSUCCESSFUL) {
> 
> apm_cmd->status is a plain memory read, and neither outb() nor inb()
> tells the compiler that memory may have changed, so the compiler
> assumes status is still -1. The loop then has no side effects and its
> return value is not used, so it is removed entirely: in the generated
> code, the read of the control port is followed directly by the return.
> The kernel goes on to power off right after raising the host control
> SMI, without waiting for the BIOS to accept it.
> 
> Poll the status with read_poll_timeout_atomic() and READ_ONCE(), 1us
> apart, for up to TIMEOUT_USEC_SHORT_SEMA_BLOCKING microseconds as the
> name suggests. The type 1 loop polls an I/O port, which already takes
> about a microsecond per read, and is left alone.

...

>  #include <linux/io.h>
> +#include <linux/iopoll.h>

You may replace io.h with iopoll.h.

...

> -		num_ticks = TIMEOUT_USEC_SHORT_SEMA_BLOCKING;
> -		while (apm_cmd->status == ESM_STATUS_CMD_UNSUCCESSFUL) {
> -			num_ticks--;
> -			if (num_ticks == EXPIRED_TIMER)
> -				return -ETIME;
> -		}
> +		if (read_poll_timeout_atomic(READ_ONCE, cmd_status,
> +					     cmd_status != ESM_STATUS_CMD_UNSUCCESSFUL,
> +					     1, TIMEOUT_USEC_SHORT_SEMA_BLOCKING,
> +					     false, apm_cmd->status))
> +			return -ETIME;

Find the difference between -ETIME and -ETIMEDOUT. Besides that, you
effectively ignored the return value of the call. Why?

And on top, this is an inconsistent change, the function AFACS has two of a
such that may be replaced at once.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-16 11:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14  6:17 [PATCH 0/5] platform/x86: dell: dcdbas: Fix SMI completion wait and buffer handling Rosen Penev
2026-11-14  6:17 ` [PATCH 1/5] platform/x86: dell: dcdbas: Actually wait for the host control SMI Rosen Penev
2026-11-16 11:17   ` Andy Shevchenko [this message]
2026-11-14  6:17 ` [PATCH 2/5] platform/x86: dell: dcdbas: Suppress bind attributes of the platform driver Rosen Penev
2026-11-16 11:18   ` Andy Shevchenko
2026-11-14  6:17 ` [PATCH 3/5] platform/x86: dell: dcdbas: Release the SMI buffer in remove Rosen Penev
2026-11-16 11:24   ` Andy Shevchenko
2026-11-14  6:17 ` [PATCH 4/5] platform/x86: dell: dcdbas: Validate the WSMT buffer description Rosen Penev
2026-11-16 11:43   ` Andy Shevchenko
2026-11-14  6:17 ` [PATCH 5/5] platform/x86: dell: dcdbas: Use read_poll_timeout_atomic() for the type 1 SMI Rosen Penev
2026-11-16 11:44   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avrmYDgb06et2lj4@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Douglas_Warzecha@dell.com \
    --cc=akpm@osdl.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rosenp@gmail.com \
    --cc=stuart.w.hayes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®