mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: "Stuart Hayes" <stuart.w.hayes@gmail.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Doug Warzecha" <Douglas_Warzecha@dell.com>,
	"Andrew Morton" <akpm@osdl.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] platform/x86: dell: dcdbas: Release the SMI buffer in remove
Date: Mon, 16 Nov 2026 13:24:13 +0200	[thread overview]
Message-ID: <avrn3cn5yX2LTZ2u@ashevche-desk.local> (raw)
In-Reply-To: <a486b9714c8e58761e6368e7d75169441ce87e96.1794633178.git.rosenp@gmail.com>

On Fri, Nov 13, 2026 at 10:17:56PM -0800, Rosen Penev wrote:
> dcdbas_exit() frees the SMI data buffer before
> platform_device_unregister() removes the sysfs attributes, and without
> holding smi_data_lock. The comment claims that only at module exit can
> all sysfs attributes be released, but device attributes do not pin the
> module: while rmmod runs, smi_data_write() or smi_data_buf_size_store()
> can still be executing. They can then memcpy() into the buffer as it is
> freed, or allocate a new buffer that is never freed.
> 
> sysfs_remove_group() in dcdbas_remove() waits for running attribute
> handlers, and dcdbas_pdev is still valid at that point. Free the buffer
> there, or unmap the firmware-provided buffer when WSMT is in use, and
> also do it when probe fails after dcdbas_check_wsmt() mapped the
> firmware buffer. Reset the WSMT state with it so a later probe starts
> clean.

...

> +/**

Really? If so, can you validate this with kernel-doc?

> + * dcdbas_release_buffer: free the SMI data buffer or unmap the WSMT one
> + */

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-16 11:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14  6:17 [PATCH 0/5] platform/x86: dell: dcdbas: Fix SMI completion wait and buffer handling Rosen Penev
2026-11-14  6:17 ` [PATCH 1/5] platform/x86: dell: dcdbas: Actually wait for the host control SMI Rosen Penev
2026-11-16 11:17   ` Andy Shevchenko
2026-11-14  6:17 ` [PATCH 2/5] platform/x86: dell: dcdbas: Suppress bind attributes of the platform driver Rosen Penev
2026-11-16 11:18   ` Andy Shevchenko
2026-11-14  6:17 ` [PATCH 3/5] platform/x86: dell: dcdbas: Release the SMI buffer in remove Rosen Penev
2026-11-16 11:24   ` Andy Shevchenko [this message]
2026-11-14  6:17 ` [PATCH 4/5] platform/x86: dell: dcdbas: Validate the WSMT buffer description Rosen Penev
2026-11-16 11:43   ` Andy Shevchenko
2026-11-14  6:17 ` [PATCH 5/5] platform/x86: dell: dcdbas: Use read_poll_timeout_atomic() for the type 1 SMI Rosen Penev
2026-11-16 11:44   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avrn3cn5yX2LTZ2u@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Douglas_Warzecha@dell.com \
    --cc=akpm@osdl.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rosenp@gmail.com \
    --cc=stuart.w.hayes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®