mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/3] media: atomisp: Remove unused any_virq_signal()
@ 2026-11-16 12:06 Avishek Chaulagain
  2026-11-16 12:06 ` [PATCH 2/3] media: atomisp: Remove unused get_sp_code_addr() Avishek Chaulagain
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Avishek Chaulagain @ 2026-11-16 12:06 UTC (permalink / raw)
  To: Hans de Goede, Mauro Carvalho Chehab, Greg Kroah-Hartman
  Cc: Sakari Ailus, Andy Shevchenko, linux-media, linux-staging,
	linux-kernel, Avishek Chaulagain

any_virq_signal() has no callers anywhere in the tree. Remove the
unused function and its declaration.

Signed-off-by: Avishek Chaulagain <chaulagainavishek14@gmail.com>
---
 .../media/atomisp/pci/hive_isp_css_common/host/irq.c      | 8 --------
 .../atomisp/pci/hive_isp_css_include/host/irq_public.h    | 1 -
 2 files changed, 9 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c
index 61dea3863..f1b01f5f9 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c
@@ -215,14 +215,6 @@ void irq_raise(
 	return;
 }
 
-bool any_virq_signal(void)
-{
-	unsigned int irq_status = irq_reg_load(IRQ0_ID,
-					       _HRT_IRQ_CONTROLLER_STATUS_REG_IDX);
-
-	return (irq_status != 0);
-}
-
 void cnd_virq_enable_channel(
     const enum virq_id				irq_ID,
     const bool					en)
diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/irq_public.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/irq_public.h
index 901e10f87..d7ff06219 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/irq_public.h
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/irq_public.h
@@ -107,7 +107,6 @@ void irq_raise(
 
  \return any(VIRQ.channel[irq_ID] != 0)
  */
-bool any_virq_signal(void);
 
 /*! Enable an IRQ channel of the virtual super IRQ
 
-- 
2.43.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/3] media: atomisp: Remove unused get_sp_code_addr()
  2026-11-16 12:06 [PATCH 1/3] media: atomisp: Remove unused any_virq_signal() Avishek Chaulagain
@ 2026-11-16 12:06 ` Avishek Chaulagain
  2026-11-16 12:38   ` Dan Carpenter
  2026-11-16 12:06 ` [PATCH 3/3] media: atomisp: Remove unused hmm_flush() Avishek Chaulagain
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Avishek Chaulagain @ 2026-11-16 12:06 UTC (permalink / raw)
  To: Hans de Goede, Mauro Carvalho Chehab, Greg Kroah-Hartman
  Cc: Sakari Ailus, Andy Shevchenko, linux-media, linux-staging,
	linux-kernel, Avishek Chaulagain

get_sp_code_addr() has no callers anywhere in the tree. Remove the
unused function and its declaration.

Signed-off-by: Avishek Chaulagain <chaulagainavishek14@gmail.com>
---
 .../atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h     | 1 -
 .../staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c    | 5 -----
 2 files changed, 6 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h b/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h
index 3cd69284f..e00308818 100644
--- a/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h
+++ b/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h
@@ -26,7 +26,6 @@ typedef struct {
 } ia_css_spctrl_cfg;
 
 /* Get the code addr in DDR of SP */
-ia_css_ptr get_sp_code_addr(sp_ID_t  sp_id);
 
 /* ! Load firmware on to specfied SP
 */
diff --git a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c
index 78f00f07b..49b986351 100644
--- a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c
+++ b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c
@@ -104,11 +104,6 @@ void sh_css_spctrl_reload_fw(sp_ID_t sp_id)
 	spctrl_loaded[sp_id] = true;
 }
 
-ia_css_ptr get_sp_code_addr(sp_ID_t  sp_id)
-{
-	return spctrl_cofig_info[sp_id].code_addr;
-}
-
 int ia_css_spctrl_unload_fw(sp_ID_t sp_id)
 {
 	if ((sp_id >= N_SP_ID) || ((sp_id < N_SP_ID) && (!spctrl_loaded[sp_id])))
-- 
2.43.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 3/3] media: atomisp: Remove unused hmm_flush()
  2026-11-16 12:06 [PATCH 1/3] media: atomisp: Remove unused any_virq_signal() Avishek Chaulagain
  2026-11-16 12:06 ` [PATCH 2/3] media: atomisp: Remove unused get_sp_code_addr() Avishek Chaulagain
@ 2026-11-16 12:06 ` Avishek Chaulagain
  2026-11-16 12:38 ` [PATCH 1/3] media: atomisp: Remove unused any_virq_signal() Dan Carpenter
  2026-11-16 14:20 ` Andy Shevchenko
  3 siblings, 0 replies; 6+ messages in thread
From: Avishek Chaulagain @ 2026-11-16 12:06 UTC (permalink / raw)
  To: Hans de Goede, Mauro Carvalho Chehab, Greg Kroah-Hartman
  Cc: Sakari Ailus, Andy Shevchenko, linux-media, linux-staging,
	linux-kernel, Avishek Chaulagain

hmm_flush() has no callers anywhere in the tree. Remove the
unused function and its declaration.

Signed-off-by: Avishek Chaulagain <chaulagainavishek14@gmail.com>
---
 drivers/staging/media/atomisp/include/hmm/hmm.h | 1 -
 drivers/staging/media/atomisp/pci/hmm/hmm.c     | 5 -----
 2 files changed, 6 deletions(-)

diff --git a/drivers/staging/media/atomisp/include/hmm/hmm.h b/drivers/staging/media/atomisp/include/hmm/hmm.h
index a7aef27f5..545bb52c5 100644
--- a/drivers/staging/media/atomisp/include/hmm/hmm.h
+++ b/drivers/staging/media/atomisp/include/hmm/hmm.h
@@ -32,7 +32,6 @@ void hmm_free(ia_css_ptr ptr);
 int hmm_load(ia_css_ptr virt, void *data, unsigned int bytes);
 int hmm_store(ia_css_ptr virt, const void *data, unsigned int bytes);
 int hmm_set(ia_css_ptr virt, int c, unsigned int bytes);
-int hmm_flush(ia_css_ptr virt, unsigned int bytes);
 
 /*
  * get kernel memory physical address from ISP virtual address.
diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm.c b/drivers/staging/media/atomisp/pci/hmm/hmm.c
index f998b57f9..f9abb1618 100644
--- a/drivers/staging/media/atomisp/pci/hmm/hmm.c
+++ b/drivers/staging/media/atomisp/pci/hmm/hmm.c
@@ -263,11 +263,6 @@ int hmm_load(ia_css_ptr virt, void *data, unsigned int bytes)
 }
 
 /* Flush hmm data from the data cache */
-int hmm_flush(ia_css_ptr virt, unsigned int bytes)
-{
-	return load_and_flush(virt, NULL, bytes);
-}
-
 /* Write function in ISP memory management */
 int hmm_store(ia_css_ptr virt, const void *data, unsigned int bytes)
 {
-- 
2.43.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/3] media: atomisp: Remove unused any_virq_signal()
  2026-11-16 12:06 [PATCH 1/3] media: atomisp: Remove unused any_virq_signal() Avishek Chaulagain
  2026-11-16 12:06 ` [PATCH 2/3] media: atomisp: Remove unused get_sp_code_addr() Avishek Chaulagain
  2026-11-16 12:06 ` [PATCH 3/3] media: atomisp: Remove unused hmm_flush() Avishek Chaulagain
@ 2026-11-16 12:38 ` Dan Carpenter
  2026-11-16 14:20 ` Andy Shevchenko
  3 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2026-11-16 12:38 UTC (permalink / raw)
  To: Avishek Chaulagain
  Cc: Hans de Goede, Mauro Carvalho Chehab, Greg Kroah-Hartman,
	Sakari Ailus, Andy Shevchenko, linux-media, linux-staging,
	linux-kernel

On Mon, Nov 16, 2026 at 12:06:56PM +0000, Avishek Chaulagain wrote:
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/irq_public.h
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/irq_public.h
> @@ -107,7 +107,6 @@ void irq_raise(
>  
>   \return any(VIRQ.channel[irq_ID] != 0)
>   */
> -bool any_virq_signal(void);

This leaves a dangling comment.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/3] media: atomisp: Remove unused get_sp_code_addr()
  2026-11-16 12:06 ` [PATCH 2/3] media: atomisp: Remove unused get_sp_code_addr() Avishek Chaulagain
@ 2026-11-16 12:38   ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2026-11-16 12:38 UTC (permalink / raw)
  To: Avishek Chaulagain
  Cc: Hans de Goede, Mauro Carvalho Chehab, Greg Kroah-Hartman,
	Sakari Ailus, Andy Shevchenko, linux-media, linux-staging,
	linux-kernel

On Mon, Nov 16, 2026 at 12:06:57PM +0000, Avishek Chaulagain wrote:
> get_sp_code_addr() has no callers anywhere in the tree. Remove the
> unused function and its declaration.
> 
> Signed-off-by: Avishek Chaulagain <chaulagainavishek14@gmail.com>
> ---
>  .../atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h     | 1 -
>  .../staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c    | 5 -----
>  2 files changed, 6 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h b/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h
> index 3cd69284f..e00308818 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h
> +++ b/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h
> @@ -26,7 +26,6 @@ typedef struct {
>  } ia_css_spctrl_cfg;
>  
>  /* Get the code addr in DDR of SP */
> -ia_css_ptr get_sp_code_addr(sp_ID_t  sp_id);

Dangling comment.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/3] media: atomisp: Remove unused any_virq_signal()
  2026-11-16 12:06 [PATCH 1/3] media: atomisp: Remove unused any_virq_signal() Avishek Chaulagain
                   ` (2 preceding siblings ...)
  2026-11-16 12:38 ` [PATCH 1/3] media: atomisp: Remove unused any_virq_signal() Dan Carpenter
@ 2026-11-16 14:20 ` Andy Shevchenko
  3 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2026-11-16 14:20 UTC (permalink / raw)
  To: Avishek Chaulagain
  Cc: Hans de Goede, Mauro Carvalho Chehab, Greg Kroah-Hartman,
	Sakari Ailus, Andy Shevchenko, linux-media, linux-staging,
	linux-kernel

On Mon, Nov 16, 2026 at 12:06:56PM +0000, Avishek Chaulagain wrote:
> any_virq_signal() has no callers anywhere in the tree. Remove the
> unused function and its declaration.

...

>  
>   \return any(VIRQ.channel[irq_ID] != 0)
>   */

Do we still need a comment?

> -bool any_virq_signal(void);

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-16 14:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16 12:06 [PATCH 1/3] media: atomisp: Remove unused any_virq_signal() Avishek Chaulagain
2026-11-16 12:06 ` [PATCH 2/3] media: atomisp: Remove unused get_sp_code_addr() Avishek Chaulagain
2026-11-16 12:38   ` Dan Carpenter
2026-11-16 12:06 ` [PATCH 3/3] media: atomisp: Remove unused hmm_flush() Avishek Chaulagain
2026-11-16 12:38 ` [PATCH 1/3] media: atomisp: Remove unused any_virq_signal() Dan Carpenter
2026-11-16 14:20 ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®