mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Andersson <andersson@kernel.org>
To: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
Cc: "Anvesh Jain P" <anvesh.p@oss.qualcomm.com>,
	"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
	"Sibi Sankar" <sibi.sankar@oss.qualcomm.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: glymur: Add EC thermal zones
Date: Mon, 16 Nov 2026 15:56:52 -0600	[thread overview]
Message-ID: <avt6-driUZyXA_9N@zenbook> (raw)
In-Reply-To: <c3de7659-726c-4fbe-989e-148bcd13bc49@oss.qualcomm.com>

On Mon, Nov 02, 2026 at 04:36:16PM +0530, Manaf Meethalavalappu Pallikunhi wrote:
> Hi Konrad,
> 
> On 10/29/2026 2:38 PM, Anvesh Jain P wrote:
> > 
> > 
> > On 10/20/2026 1:33 PM, Konrad Dybcio wrote:
> > > > Add support for back cover, keyboard, and SoC thermal zones through
> > > > temperature sensors hosted on the EC for Glymur and Mahua CRDs.
> > > > 
> > > > Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
> > > > ---
> > > >   arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 45 +++++++++++++++++++++++++++++++-
> > > >   1 file changed, 44 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> > > > index e27c697e3170..571c98124a40 100644
> > > > --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> > > > +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> > > > @@ -594,10 +594,12 @@ &i2c9 {
> > > >   	status = "okay";
> > > > -	embedded-controller@76 {
> > > > +	ec: embedded-controller@76 {
> > > "ec" is a super short label, perhaps let's spell out
> > > embedded_controller
> > > 
> > 
> > Thanks for you review, I will rename the label to embedded_controller.
> > > [...]
> > > 
> > > > +&thermal_zones {
> > > > +	ec-back-cover {
> > > > +		polling-delay = <10000>;
> > > > +		thermal-sensors = <&ec 2>;
> > > > +
> > > > +		trips {
> > > > +			trip-point0 {
> > > > +				temperature = <90000>;
> > > This is *really* hot!
> > > 
> > 
> > The 90°C trip value was suggested by thermal team(Manaf Meethalavalappu
> > Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>). We are open to using a
> > lower value if this is too high for the keyboard and back-cover sensors.
> 
> These sensors are intended to be controlled primarily from userspace by the
> thermal governor in thermald, through the powercap sysfs interface [1]. We
> do not plan to add cooling bindings for these thermal zones.
> 

I don't plan to merge settings that will cause physical harm to people
who for some reason doesn't run your userspace tool.

> Based on discussions with the tuning team, we agreed on a hot-trip threshold
> of 90°C for these sensors.
> 

Please make tuning team that the user might/will bring their own
userspace, with or without this configuration.

E.g. on my system there doesn't seem to be anything called "thermald":

$ pacman -Ss thermald |wc -l
0

Thanks,
Bjorn

> [1] https://github.com/intel/thermal_daemon/pull/614/commits/7f3dd62353e039957e52eeb40c67ec388d543ebe
> 
> Thanks,
> Manaf
> 
> > > > +				hysteresis = <5000>;
> > > > +				type = "hot";
> > > > +			};
> > > > +		};
> > > > +	};
> > > > +
> > > > +	ec-keyboard {
> > > > +		polling-delay = <10000>;
> > > > +		thermal-sensors = <&ec 1>;
> > > > +
> > > > +		trips {
> > > > +			trip-point0 {
> > > > +				temperature = <90000>;
> > > Likewise
> > > 
> > > Konrad
> > 
> 

      parent reply	other threads:[~2026-11-16 21:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28  6:36 [PATCH 0/3] platform: arm64: qcom-hamoa-ec: Add thermistor support Anvesh Jain P
2026-09-28  6:36 ` [PATCH 1/3] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add thermal sensors Anvesh Jain P
2026-09-28  6:36 ` [PATCH 2/3] platform: arm64: qcom-hamoa-ec: Add thermistor sensors Anvesh Jain P
2026-09-29  7:35   ` Ilpo Järvinen
2026-09-30  5:02     ` Anvesh Jain P
2026-09-28  6:36 ` [PATCH 3/3] arm64: dts: qcom: glymur: Add EC thermal zones Anvesh Jain P
2026-09-29  8:56   ` Krzysztof Kozlowski
2026-09-29 10:07     ` Anvesh Jain P
2026-10-20  8:03   ` Konrad Dybcio
2026-10-29  9:08     ` Anvesh Jain P
2026-11-02 11:06       ` Manaf Meethalavalappu Pallikunhi
2026-11-02 11:11         ` Konrad Dybcio
2026-11-16 21:56         ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avt6-driUZyXA_9N@zenbook \
    --to=andersson@kernel.org \
    --cc=anvesh.p@oss.qualcomm.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manaf.pallikunhi@oss.qualcomm.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sibi.sankar@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®