From: Chen Yu <yu.c.chen@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: kernel test robot <yi1.lai@intel.com>, <oe-lkp@lists.linux.dev>,
<lkp@intel.com>, Tony Luck <tony.luck@intel.com>,
Jinjie Ruan <ruanjinjie@huawei.com>,
<linux-kernel@vger.kernel.org>, <ben.horgan@arm.com>,
<james.morse@arm.com>, <Dave.Martin@arm.com>,
<babu.moger@amd.com>, <bp@alien8.de>, <tglx@linutronix.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<fustini@kernel.org>, <fenghuay@nvidia.com>,
<peternewman@google.com>, <patches@lists.linux.dev>
Subject: Re: [PATCH v3 2/5] x86,fs/resctrl: Remove unnecessary non-linear MBA configuration check
Date: Tue, 17 Nov 2026 12:55:18 +0800 [thread overview]
Message-ID: <avveNoKuHfomEHj0@chenyu-dev> (raw)
In-Reply-To: <8fb8b947-482a-48be-8618-32989a840dfa@intel.com>
On Mon, Nov 16, 2026 at 08:20:06PM -0800, Reinette Chatre wrote:
> Hi,
>
> On 11/16/26 7:36 PM, kernel test robot wrote:
> >
> > Hello,
> >
> > kernel test robot noticed a 4.4% regression of stress-ng.sockfd.ops_per_sec on:
> >
> > commit: 12a0f554b3d62eb1270d6d60e9c6ab2c07dbbe35 ("[PATCH v3 2/5] x86,fs/resctrl: Remove unnecessary non-linear MBA configuration check")
> > url: https://github.com/intel-lab-lkp/linux/commits/Reinette-Chatre/x86-fs-resctrl-Remove-unused-non-linear-bandwidth-delay-mapping/20261104-161329
> > patch link: https://lore.kernel.org/all/7e1aeee81a38a33ca889db68e4c645f935e4e6cd.1793834224.git.reinette.chatre@intel.com/
> > patch subject: [PATCH v3 2/5] x86,fs/resctrl: Remove unnecessary non-linear MBA configuration check
> >
> > testcase: stress-ng
> > config: x86_64-rhel-9.4
> > compiler: gcc-14
> > test machine: 224 threads 2 sockets Intel(R) Xeon(R) Platinum 8480CTDX (Sapphire Rapids) with 256G memory
> > parameters:
> >
> > nr_threads: 100%
> > testtime: 60s
> > test: sockfd
> > cpufreq_governor: performance
> >
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <yi1.lai@intel.com>
> > | Closes: https://lore.kernel.org/oe-lkp/202611171056.912725cf-lkp@intel.com
> >
> >
> > Details are as below:
> > -------------------------------------------------------------------------------------------------->
> >
> >
> > The kernel config and materials to reproduce are available at:
> > https://download.01.org/0day-ci/archive/20261117/202611171056.912725cf-lkp@intel.com
> >
> > =========================================================================================
> > compiler/cpufreq_governor/kconfig/nr_threads/rootfs/tbox_group/test/testcase/testtime:
> > gcc-14/performance/x86_64-rhel-9.4/100%/debian-13-x86_64-20250902.cgz/lkp-spr-r02/sockfd/stress-ng/60s
> >
> > commit:
> > 0d4f0ec1db ("x86,fs/resctrl: Remove unused non-linear bandwidth delay mapping")
> > 12a0f554b3 ("[PATCH v3 2/5] x86,fs/resctrl: Remove unnecessary non-linear MBA configuration check")
> >
> > 0d4f0ec1dbca25be 12a0f554b3d62eb1270d6d60e9c
> > ---------------- ---------------------------
> > %stddev %change %stddev
> > \ | \
> > 56484401 -4.4% 54013430 stress-ng.sockfd.ops
> > 940555 -4.4% 899375 stress-ng.sockfd.ops_per_sec
> > 3901263 -1.5% 3841842 stress-ng.time.involuntary_context_switches
> > 2386355 ± 6% -10.4% 2138169 ± 5% stress-ng.time.voluntary_context_switches
> >
> I am unable to see the connection between this test and the patch identified.
>
> The patch identified is a resctrl change and looking at the reproducer script
> resctrl was not mounted during the test. The kernel config does have
> CONFIG_X86_CPU_RESCTRL=y so resctrl will do its enumeration and then just do
> nothing until resctrl is mounted, which never happens.
>
> The patch does remove a struct member so this does change the resctrl memory
> layout. The structure changed, resctrl_membw, can be found in rdt_resources_all[]
> that is a writable global with static storage. I expect it to be located in
> .data. Could this possibly impact the test?
>
I agree. I think this is a data layout change, not a real regression in the code.
rdt_resources_all[] is in .data, and arch/x86 is linked before net/, So all the .data
variables after the shrink of struct resctrl_membw moves ahead, then variables in the
network component share a cache line with different neighbors. I don't think resctrl
should change anything for this, perf c2c on sockfd should show which hot global
variable is sharing a cache line, and that variable should be cache aligned.
thanks,
Chenyu
next prev parent reply other threads:[~2026-11-17 5:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 0:13 [PATCH v3 0/5] x86,fs/resctrl: Cleanups in preparation for multiple controls support Reinette Chatre
2026-11-05 0:13 ` [PATCH v3 1/5] x86,fs/resctrl: Remove unused non-linear bandwidth delay mapping Reinette Chatre
2026-11-05 0:13 ` [PATCH v3 2/5] x86,fs/resctrl: Remove unnecessary non-linear MBA configuration check Reinette Chatre
2026-11-17 3:36 ` kernel test robot
2026-11-17 4:20 ` Reinette Chatre
2026-11-17 4:55 ` Chen Yu [this message]
2026-11-05 0:13 ` [PATCH v3 3/5] x86,fs/resctrl: Move MSR_IA32_L{2,3}_QOS_CFG scope property to x86 resource Reinette Chatre
2026-11-05 0:13 ` [PATCH v3 4/5] fs/resctrl: Drop unnecessary is_mba_linear() helper Reinette Chatre
2026-11-05 0:13 ` [PATCH v3 5/5] fs/resctrl: Drop unnecessary parameter from resctrl_io_alloc_parse_line() Reinette Chatre
2026-11-05 0:26 ` [PATCH v3 0/5] x86,fs/resctrl: Cleanups in preparation for multiple controls support Reinette Chatre
2026-11-09 1:46 ` Borislav Petkov
2026-11-09 22:23 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avveNoKuHfomEHj0@chenyu-dev \
--to=yu.c.chen@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=ben.horgan@arm.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=fustini@kernel.org \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=reinette.chatre@intel.com \
--cc=ruanjinjie@huawei.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yi1.lai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®