From: Viresh Kumar <viresh.kumar@linaro.org>
To: David Yang <mmyangfl@gmail.com>
Cc: linux-watchdog@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Viresh Kumar <vireshk@kernel.org>,
Andre Przywara <andre.przywara@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: arm,sp805: reference the PrimeCell binding
Date: Tue, 17 Nov 2026 11:00:39 +0530 [thread overview]
Message-ID: <avvmf71B4E2mKrgN@vireshk-B250M-D3H> (raw)
In-Reply-To: <20261114184257.535546-1-mmyangfl@gmail.com>
On 15-11-26, 02:42, David Yang wrote:
> Unlike the other PrimeCell bindings, the binding ends in
> unevaluatedProperties: false without referencing
> /schemas/arm/primecell.yaml#, so arm,primecell-periphid is not an
> evaluated property on an arm,sp805 node. Two nodes in the tree carry
> that property regardless -- watchdog@a2c000 in hisi-x5hd2.dtsi and
> watchdog@8000 in mps2.dtsi.
>
> `make CHECK_DTBS=y`:
>
> watchdog@a2c000 (arm,sp805): Unevaluated properties are not allowed
> ('arm,primecell-periphid' was unexpected)
>
> Add the reference so the property becomes evaluable; both nodes then
> validate.
>
> Fixes: 73d3e43f9813 ("dt-bindings: watchdog: sp-805: Convert to Json-schema")
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
> Documentation/devicetree/bindings/watchdog/arm,sp805.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> index bd7c09ed1938..690456839fcc 100644
> --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> @@ -16,6 +16,7 @@ description: |+
>
> allOf:
> - $ref: /schemas/watchdog/watchdog.yaml#
> + - $ref: /schemas/arm/primecell.yaml#
>
> # Need a custom select here or 'arm,primecell' will match on lots of nodes
> select:
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
prev parent reply other threads:[~2026-11-17 5:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 18:42 David Yang
2026-11-17 5:30 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avvmf71B4E2mKrgN@vireshk-B250M-D3H \
--to=viresh.kumar@linaro.org \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mmyangfl@gmail.com \
--cc=robh@kernel.org \
--cc=vireshk@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®