mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: watchdog: arm,sp805: reference the PrimeCell binding
@ 2026-11-14 18:42 David Yang
  2026-11-17  5:30 ` Viresh Kumar
  0 siblings, 1 reply; 2+ messages in thread
From: David Yang @ 2026-11-14 18:42 UTC (permalink / raw)
  To: linux-watchdog
  Cc: David Yang, Wim Van Sebroeck, Guenter Roeck, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Viresh Kumar, Andre Przywara,
	devicetree, linux-kernel

Unlike the other PrimeCell bindings, the binding ends in
unevaluatedProperties: false without referencing
/schemas/arm/primecell.yaml#, so arm,primecell-periphid is not an
evaluated property on an arm,sp805 node. Two nodes in the tree carry
that property regardless -- watchdog@a2c000 in hisi-x5hd2.dtsi and
watchdog@8000 in mps2.dtsi.

`make CHECK_DTBS=y`:

  watchdog@a2c000 (arm,sp805): Unevaluated properties are not allowed
  ('arm,primecell-periphid' was unexpected)

Add the reference so the property becomes evaluable; both nodes then
validate.

Fixes: 73d3e43f9813 ("dt-bindings: watchdog: sp-805: Convert to Json-schema")
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
 Documentation/devicetree/bindings/watchdog/arm,sp805.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
index bd7c09ed1938..690456839fcc 100644
--- a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
+++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
@@ -16,6 +16,7 @@ description: |+
 
 allOf:
   - $ref: /schemas/watchdog/watchdog.yaml#
+  - $ref: /schemas/arm/primecell.yaml#
 
 # Need a custom select here or 'arm,primecell' will match on lots of nodes
 select:
-- 
2.53.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: watchdog: arm,sp805: reference the PrimeCell binding
  2026-11-14 18:42 [PATCH] dt-bindings: watchdog: arm,sp805: reference the PrimeCell binding David Yang
@ 2026-11-17  5:30 ` Viresh Kumar
  0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2026-11-17  5:30 UTC (permalink / raw)
  To: David Yang
  Cc: linux-watchdog, Wim Van Sebroeck, Guenter Roeck, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Viresh Kumar, Andre Przywara,
	devicetree, linux-kernel

On 15-11-26, 02:42, David Yang wrote:
> Unlike the other PrimeCell bindings, the binding ends in
> unevaluatedProperties: false without referencing
> /schemas/arm/primecell.yaml#, so arm,primecell-periphid is not an
> evaluated property on an arm,sp805 node. Two nodes in the tree carry
> that property regardless -- watchdog@a2c000 in hisi-x5hd2.dtsi and
> watchdog@8000 in mps2.dtsi.
> 
> `make CHECK_DTBS=y`:
> 
>   watchdog@a2c000 (arm,sp805): Unevaluated properties are not allowed
>   ('arm,primecell-periphid' was unexpected)
> 
> Add the reference so the property becomes evaluable; both nodes then
> validate.
> 
> Fixes: 73d3e43f9813 ("dt-bindings: watchdog: sp-805: Convert to Json-schema")
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
>  Documentation/devicetree/bindings/watchdog/arm,sp805.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> index bd7c09ed1938..690456839fcc 100644
> --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> @@ -16,6 +16,7 @@ description: |+
>  
>  allOf:
>    - $ref: /schemas/watchdog/watchdog.yaml#
> +  - $ref: /schemas/arm/primecell.yaml#
>  
>  # Need a custom select here or 'arm,primecell' will match on lots of nodes
>  select:

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-17  5:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-14 18:42 [PATCH] dt-bindings: watchdog: arm,sp805: reference the PrimeCell binding David Yang
2026-11-17  5:30 ` Viresh Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®