* [PATCH] drm: renesas: rz-du: Add suspend/resume support
@ 2026-11-12 8:24 Tommaso Merciai
2026-11-17 15:12 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Tommaso Merciai @ 2026-11-12 8:24 UTC (permalink / raw)
To: Biju Das, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter
Cc: dri-devel, linux-renesas-soc, linux-kernel, tomm.merciai,
Tommaso Merciai
Add suspend/resume support to the RZ/G2L DU driver.
Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
index 6c2dc86abc7d..c7d71dd9198e 100644
--- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
+++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
@@ -140,6 +140,27 @@ static const struct drm_driver rzg2l_du_driver = {
.minor = 0,
};
+/* -----------------------------------------------------------------------------
+ * Power management
+ */
+
+static int rzg2l_du_pm_suspend(struct device *dev)
+{
+ struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
+
+ return drm_mode_config_helper_suspend(&rcdu->ddev);
+}
+
+static int rzg2l_du_pm_resume(struct device *dev)
+{
+ struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
+
+ return drm_mode_config_helper_resume(&rcdu->ddev);
+}
+
+static DEFINE_SIMPLE_DEV_PM_OPS(rzg2l_du_pm_ops,
+ rzg2l_du_pm_suspend, rzg2l_du_pm_resume);
+
/* -----------------------------------------------------------------------------
* Platform driver
*/
@@ -227,6 +248,7 @@ static struct platform_driver rzg2l_du_platform_driver = {
.remove = rzg2l_du_remove,
.shutdown = rzg2l_du_shutdown,
.driver = {
+ .pm = pm_sleep_ptr(&rzg2l_du_pm_ops),
.name = "rzg2l-du",
.of_match_table = rzg2l_du_of_table,
},
---
base-commit: 630059a5a632377b9b7b487baccde92b7ae1dd47
change-id: 20261112-b4-tm-pm-du-edc079c59a9f
Best regards,
--
Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: renesas: rz-du: Add suspend/resume support
2026-11-12 8:24 [PATCH] drm: renesas: rz-du: Add suspend/resume support Tommaso Merciai
@ 2026-11-17 15:12 ` Geert Uytterhoeven
2026-11-17 15:30 ` Tommaso Merciai
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2026-11-17 15:12 UTC (permalink / raw)
To: Tommaso Merciai
Cc: Biju Das, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, dri-devel, linux-renesas-soc,
linux-kernel, tomm.merciai
Hi Tommaso,
On Thu, 12 Nov 2026 at 09:31, Tommaso Merciai
<tommaso.merciai.xr@bp.renesas.com> wrote:
> Add suspend/resume support to the RZ/G2L DU driver.
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Thanks for your patch!
> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> @@ -140,6 +140,27 @@ static const struct drm_driver rzg2l_du_driver = {
> .minor = 0,
> };
>
> +/* -----------------------------------------------------------------------------
> + * Power management
> + */
> +
> +static int rzg2l_du_pm_suspend(struct device *dev)
> +{
> + struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
> +
> + return drm_mode_config_helper_suspend(&rcdu->ddev);
error: passing argument 1 of ‘drm_mode_config_helper_suspend’ from
incompatible pointer type [-Werror=incompatible-pointer-types]
The "&" should be dropped...
> +}
> +
> +static int rzg2l_du_pm_resume(struct device *dev)
> +{
> + struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
> +
> + return drm_mode_config_helper_resume(&rcdu->ddev);
... likewise.
> +}
> +
> +static DEFINE_SIMPLE_DEV_PM_OPS(rzg2l_du_pm_ops,
> + rzg2l_du_pm_suspend, rzg2l_du_pm_resume);
> +
> /* -----------------------------------------------------------------------------
> * Platform driver
> */
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: renesas: rz-du: Add suspend/resume support
2026-11-17 15:12 ` Geert Uytterhoeven
@ 2026-11-17 15:30 ` Tommaso Merciai
2026-11-17 15:37 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Tommaso Merciai @ 2026-11-17 15:30 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Biju Das, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, dri-devel, linux-renesas-soc,
linux-kernel, tomm.merciai
Hi Geert,
Thanks for your review.
On Tue, Nov 17, 2026 at 04:12:43PM +0100, Geert Uytterhoeven wrote:
> Hi Tommaso,
>
> On Thu, 12 Nov 2026 at 09:31, Tommaso Merciai
> <tommaso.merciai.xr@bp.renesas.com> wrote:
> > Add suspend/resume support to the RZ/G2L DU driver.
> >
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> > @@ -140,6 +140,27 @@ static const struct drm_driver rzg2l_du_driver = {
> > .minor = 0,
> > };
> >
> > +/* -----------------------------------------------------------------------------
> > + * Power management
> > + */
> > +
> > +static int rzg2l_du_pm_suspend(struct device *dev)
> > +{
> > + struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
> > +
> > + return drm_mode_config_helper_suspend(&rcdu->ddev);
>
> error: passing argument 1 of ‘drm_mode_config_helper_suspend’ from
> incompatible pointer type [-Werror=incompatible-pointer-types]
>
> The "&" should be dropped...
Sorry are you apply this patch on top of some other series?
On top of next-20261116 I'm not seeing this issue.
Maybe I'm missing somenthing?
Thanks in advance.
Kind regards,
Tommaso
>
> > +}
> > +
> > +static int rzg2l_du_pm_resume(struct device *dev)
> > +{
> > + struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
> > +
> > + return drm_mode_config_helper_resume(&rcdu->ddev);
>
> ... likewise.
>
> > +}
> > +
> > +static DEFINE_SIMPLE_DEV_PM_OPS(rzg2l_du_pm_ops,
> > + rzg2l_du_pm_suspend, rzg2l_du_pm_resume);
> > +
> > /* -----------------------------------------------------------------------------
> > * Platform driver
> > */
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: renesas: rz-du: Add suspend/resume support
2026-11-17 15:30 ` Tommaso Merciai
@ 2026-11-17 15:37 ` Geert Uytterhoeven
2026-11-17 15:43 ` Tommaso Merciai
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2026-11-17 15:37 UTC (permalink / raw)
To: Tommaso Merciai
Cc: Biju Das, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, dri-devel, linux-renesas-soc,
linux-kernel, tomm.merciai
Hi Tommaso,
On Tue, 17 Nov 2026 at 16:30, Tommaso Merciai
<tommaso.merciai.xr@bp.renesas.com> wrote:
> On Tue, Nov 17, 2026 at 04:12:43PM +0100, Geert Uytterhoeven wrote:
> > On Thu, 12 Nov 2026 at 09:31, Tommaso Merciai
> > <tommaso.merciai.xr@bp.renesas.com> wrote:
> > > Add suspend/resume support to the RZ/G2L DU driver.
> > >
> > > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> >
> > Thanks for your patch!
> >
> > > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> > > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> > > @@ -140,6 +140,27 @@ static const struct drm_driver rzg2l_du_driver = {
> > > .minor = 0,
> > > };
> > >
> > > +/* -----------------------------------------------------------------------------
> > > + * Power management
> > > + */
> > > +
> > > +static int rzg2l_du_pm_suspend(struct device *dev)
> > > +{
> > > + struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
> > > +
> > > + return drm_mode_config_helper_suspend(&rcdu->ddev);
> >
> > error: passing argument 1 of ‘drm_mode_config_helper_suspend’ from
> > incompatible pointer type [-Werror=incompatible-pointer-types]
> >
> > The "&" should be dropped...
>
> Sorry are you apply this patch on top of some other series?
> On top of next-20261116 I'm not seeing this issue.
>
> Maybe I'm missing somenthing?
Ah, I have your "[PATCH v9 04/10] drm: renesas: rz-du: Reference the
DRM device by pointer" applied, too...
https://patch.msgid.link/d5a97ddb346c5cb959b39fda45277afb1fa2ae16.1792770965.git.tommaso.merciai.xr@bp.renesas.com
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: renesas: rz-du: Add suspend/resume support
2026-11-17 15:37 ` Geert Uytterhoeven
@ 2026-11-17 15:43 ` Tommaso Merciai
0 siblings, 0 replies; 5+ messages in thread
From: Tommaso Merciai @ 2026-11-17 15:43 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Biju Das, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, dri-devel, linux-renesas-soc,
linux-kernel, tomm.merciai
Hi Geert,
On Tue, Nov 17, 2026 at 04:37:34PM +0100, Geert Uytterhoeven wrote:
> Hi Tommaso,
>
> On Tue, 17 Nov 2026 at 16:30, Tommaso Merciai
> <tommaso.merciai.xr@bp.renesas.com> wrote:
> > On Tue, Nov 17, 2026 at 04:12:43PM +0100, Geert Uytterhoeven wrote:
> > > On Thu, 12 Nov 2026 at 09:31, Tommaso Merciai
> > > <tommaso.merciai.xr@bp.renesas.com> wrote:
> > > > Add suspend/resume support to the RZ/G2L DU driver.
> > > >
> > > > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> > >
> > > Thanks for your patch!
> > >
> > > > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> > > > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> > > > @@ -140,6 +140,27 @@ static const struct drm_driver rzg2l_du_driver = {
> > > > .minor = 0,
> > > > };
> > > >
> > > > +/* -----------------------------------------------------------------------------
> > > > + * Power management
> > > > + */
> > > > +
> > > > +static int rzg2l_du_pm_suspend(struct device *dev)
> > > > +{
> > > > + struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
> > > > +
> > > > + return drm_mode_config_helper_suspend(&rcdu->ddev);
> > >
> > > error: passing argument 1 of ‘drm_mode_config_helper_suspend’ from
> > > incompatible pointer type [-Werror=incompatible-pointer-types]
> > >
> > > The "&" should be dropped...
> >
> > Sorry are you apply this patch on top of some other series?
> > On top of next-20261116 I'm not seeing this issue.
> >
> > Maybe I'm missing somenthing?
>
> Ah, I have your "[PATCH v9 04/10] drm: renesas: rz-du: Reference the
> DRM device by pointer" applied, too...
> https://patch.msgid.link/d5a97ddb346c5cb959b39fda45277afb1fa2ae16.1792770965.git.tommaso.merciai.xr@bp.renesas.com
Ah, thanks for sharing.
Just FYI I posted v10 [1] this apply on top of this patch.
[1] https://lore.kernel.org/all/cover.1794502191.git.tommaso.merciai.xr@bp.renesas.com/
Kind regards,
Tommaso
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-17 15:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-12 8:24 [PATCH] drm: renesas: rz-du: Add suspend/resume support Tommaso Merciai
2026-11-17 15:12 ` Geert Uytterhoeven
2026-11-17 15:30 ` Tommaso Merciai
2026-11-17 15:37 ` Geert Uytterhoeven
2026-11-17 15:43 ` Tommaso Merciai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®