* [PATCH] mips: ralink: mt7621: avoid casting away __iomem in wraparound test
@ 2026-10-04 18:48 Rosen Penev
2026-11-17 16:56 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-10-04 18:48 UTC (permalink / raw)
To: linux-mips
Cc: John Crispin, Sergio Paracuellos, Thomas Bogendoerfer,
Matthias Brugger, AngeloGioacchino Del Regno, Rosen Penev,
open list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
CPHYSADDR() casts its argument to an integer, which strips the __iomem
annotation from dm and triggers a sparse warning. Compute the physical
address from detect_magic directly. The result is unchanged since the
sum never exceeds the 512MB KSEG mask.
Fixes: 4ddaf88aadd3 ("mips: ralink: mt7621: add missing __iomem")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202610041411.uJXWXF8i-lkp@intel.com/
Assisted-by: LLM
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
arch/mips/ralink/mt7621.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/ralink/mt7621.c b/arch/mips/ralink/mt7621.c
index ae7b8cfedd5f..2d10c74b13c1 100644
--- a/arch/mips/ralink/mt7621.c
+++ b/arch/mips/ralink/mt7621.c
@@ -65,7 +65,7 @@ static bool __init mt7621_addr_wraparound_test(phys_addr_t size)
{
void __iomem *dm = (void __iomem *)KSEG1ADDR(&detect_magic);
- if (CPHYSADDR(dm + size) >= MT7621_LOWMEM_MAX_SIZE)
+ if (CPHYSADDR(&detect_magic) + size >= MT7621_LOWMEM_MAX_SIZE)
return true;
__raw_writel(MT7621_MEM_TEST_PATTERN, dm);
if (__raw_readl(dm) != __raw_readl(dm + size))
--
2.56.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mips: ralink: mt7621: avoid casting away __iomem in wraparound test
2026-10-04 18:48 [PATCH] mips: ralink: mt7621: avoid casting away __iomem in wraparound test Rosen Penev
@ 2026-11-17 16:56 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2026-11-17 16:56 UTC (permalink / raw)
To: Rosen Penev
Cc: linux-mips, John Crispin, Sergio Paracuellos, Matthias Brugger,
AngeloGioacchino Del Regno, open list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
On Sun, Oct 04, 2026 at 11:48:28AM -0700, Rosen Penev wrote:
> CPHYSADDR() casts its argument to an integer, which strips the __iomem
> annotation from dm and triggers a sparse warning. Compute the physical
> address from detect_magic directly. The result is unchanged since the
> sum never exceeds the 512MB KSEG mask.
>
> Fixes: 4ddaf88aadd3 ("mips: ralink: mt7621: add missing __iomem")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202610041411.uJXWXF8i-lkp@intel.com/
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> arch/mips/ralink/mt7621.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/mt7621.c b/arch/mips/ralink/mt7621.c
> index ae7b8cfedd5f..2d10c74b13c1 100644
> --- a/arch/mips/ralink/mt7621.c
> +++ b/arch/mips/ralink/mt7621.c
> @@ -65,7 +65,7 @@ static bool __init mt7621_addr_wraparound_test(phys_addr_t size)
> {
> void __iomem *dm = (void __iomem *)KSEG1ADDR(&detect_magic);
>
> - if (CPHYSADDR(dm + size) >= MT7621_LOWMEM_MAX_SIZE)
> + if (CPHYSADDR(&detect_magic) + size >= MT7621_LOWMEM_MAX_SIZE)
> return true;
> __raw_writel(MT7621_MEM_TEST_PATTERN, dm);
> if (__raw_readl(dm) != __raw_readl(dm + size))
> --
> 2.56.0
applied to mips-next
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-17 17:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-04 18:48 [PATCH] mips: ralink: mt7621: avoid casting away __iomem in wraparound test Rosen Penev
2026-11-17 16:56 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®