From: Cristian Marussi <cristian.marussi@arm.com>
To: Chengyu Liu <lui2012qwq@gmail.com>
Cc: Sudeep Holla <sudeep.holla@kernel.org>,
Cristian Marussi <cristian.marussi@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org,
philip.radford@arm.com, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] firmware: arm_scmi: Fix deadlock between reboot notifier and forceful work
Date: Tue, 17 Nov 2026 17:46:00 +0000 [thread overview]
Message-ID: <avyS2OLs3XGcKXXn@pluto> (raw)
In-Reply-To: <CAE=Q7=4+HMtqbiK9v3jw4t31TQOYUfRXKRurZ7KcMi7GTi1v2A@mail.gmail.com>
On Wed, Nov 18, 2026 at 01:35:04AM +0800, Chengyu Liu wrote:
> Hi,
>
> I think the current v2 may have reintroduced the second deadlock
> described in my original commit message.
>
> scmi_forceful_work_func() still calls unregister_reboot_notifier()
> while holding sc->state_mtx. Could you also check the potential lock
> inversion between state_mtx and reboot_notifier_list.rwsem?
>
> The reboot path holds the rwsem read lock while executing the notifier
> callback, which then waits for state_mtx. Meanwhile, the worker holds
> state_mtx while trying to unregister the notifier, which requires the
> rwsem write lock.
Yes indeed Sashiko complains about the same and the second part of the
issue on the rwsem is unresolved and will need more work.
Thanks,
Cristian
next prev parent reply other threads:[~2026-11-17 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 8:42 [PATCH 0/2] SCMI Power Control fixes Cristian Marussi
2026-11-16 8:42 ` [PATCH 1/2] firmware: arm_scmi: Fix deadlock between reboot notifier and forceful work Cristian Marussi
2026-11-16 18:25 ` Sudeep Holla
2026-11-17 11:25 ` Cristian Marussi
2026-11-17 14:06 ` Sudeep Holla
2026-11-17 17:35 ` Chengyu Liu
2026-11-17 17:46 ` Cristian Marussi [this message]
2026-11-16 8:42 ` [PATCH 2/2] firmware: arm_scmi: Fix SCMI Power Control driver removal Cristian Marussi
2026-11-16 18:14 ` Sudeep Holla
2026-11-17 11:35 ` Cristian Marussi
2026-11-17 14:09 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avyS2OLs3XGcKXXn@pluto \
--to=cristian.marussi@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lui2012qwq@gmail.com \
--cc=philip.radford@arm.com \
--cc=stable@vger.kernel.org \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®