* [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends'
@ 2026-11-16 22:46 Brian Norris
2026-11-17 13:53 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2026-11-16 22:46 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu
Cc: linux-kernel, linux-trace-kernel, Mathieu Desnoyers, Brian Norris
GENERIC_TRACER is not a user-selectable symbol, so it's impossible to
enable FTRACE_STARTUP_TEST unless one also enables some other symbol
that 'selects' GENERIC_TRACER for us.
This very file also suggests:
All tracer options should select GENERIC_TRACER
So, use 'select', not 'depends on'.
Fixes: 60a11774b38f ("ftrace: add self-tests")
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
kernel/trace/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 35d043b19332..8084d46ef2a0 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -1135,7 +1135,7 @@ config FTRACE_SELFTEST
config FTRACE_STARTUP_TEST
bool "Perform a startup test on ftrace"
- depends on GENERIC_TRACER
+ select GENERIC_TRACER
select FTRACE_SELFTEST
help
This option performs a series of startup tests on ftrace. On bootup
--
2.56.1.703.gf848ed807c-goog
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends'
2026-11-16 22:46 [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends' Brian Norris
@ 2026-11-17 13:53 ` Steven Rostedt
2026-11-17 17:45 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2026-11-17 13:53 UTC (permalink / raw)
To: Brian Norris
Cc: Masami Hiramatsu, linux-kernel, linux-trace-kernel, Mathieu Desnoyers
On Mon, 16 Nov 2026 14:46:53 -0800
Brian Norris <briannorris@chromium.org> wrote:
> GENERIC_TRACER is not a user-selectable symbol, so it's impossible to
> enable FTRACE_STARTUP_TEST unless one also enables some other symbol
> that 'selects' GENERIC_TRACER for us.
I believe that was the way it was intended. The selftests are to test the
things that select GENERIC_TRACER. Why would we enable tests for something
that isn't enabled?
-- Steve
>
> This very file also suggests:
>
> All tracer options should select GENERIC_TRACER
>
> So, use 'select', not 'depends on'.
>
> Fixes: 60a11774b38f ("ftrace: add self-tests")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends'
2026-11-17 13:53 ` Steven Rostedt
@ 2026-11-17 17:45 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2026-11-17 17:45 UTC (permalink / raw)
To: Steven Rostedt
Cc: Masami Hiramatsu, linux-kernel, linux-trace-kernel, Mathieu Desnoyers
On Tue, Nov 17, 2026 at 08:53:17AM -0500, Steven Rostedt wrote:
> On Mon, 16 Nov 2026 14:46:53 -0800
> Brian Norris <briannorris@chromium.org> wrote:
>
> > GENERIC_TRACER is not a user-selectable symbol, so it's impossible to
> > enable FTRACE_STARTUP_TEST unless one also enables some other symbol
> > that 'selects' GENERIC_TRACER for us.
>
> I believe that was the way it was intended. The selftests are to test the
> things that select GENERIC_TRACER. Why would we enable tests for something
> that isn't enabled?
You may have discovered in your other reply, but these tests are
applicable to code used by EVENT_TRACING, which can be enabled without
GENERIC_TRACER.
But I do see how this still might not be exactly the right choice,
especially given some of sashiko's comments.
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-17 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16 22:46 [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends' Brian Norris
2026-11-17 13:53 ` Steven Rostedt
2026-11-17 17:45 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®