From: Keith Busch <kbusch@kernel.org>
To: Zakaria Belkadi <zakaria.belkadi@inria.fr>
Cc: Christoph Hellwig <hch@infradead.org>,
Caleb Sander Mateos <csander@purestorage.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Kanchan Joshi <joshi.k@samsung.com>,
Anuj Gupta <anuj20.g@samsung.com>,
florence.schadle@ssi.gouv.fr, frederic.tronel@centralesupelec.fr,
louis.rilling@irisa.fr, stable@vger.kernel.org
Subject: Re: [PATCH RESEND] block: pin user PI pages for writing when ref tags are remapped
Date: Fri, 20 Nov 2026 09:58:32 -0700 [thread overview]
Message-ID: <awB8OODx0fCFGc5G@kbusch-mbp> (raw)
In-Reply-To: <20261120162257.498238-1-zakaria.belkadi@inria.fr>
On Fri, Nov 20, 2026 at 05:22:57PM +0100, Zakaria Belkadi wrote:
> Christoph, Caleb,
>
> Thanks to both of you for the review.
>
> On Fri, Nov 20, 2026 at 07:28:07AM -0800, Christoph Hellwig wrote:
> > I don't think we can just pin memory as writable that wasn't given to
> > us as writable. So this needs to force bounce buffering, at least when
> > remapping might be required.
>
> Agreed. I'll keep the PI iterator as ITER_SOURCE. In v2,
> bio_integrity_map_user() will bounce the user PI buffer for REQ_OP_WRITE
> when the integrity profile has BLK_INTEGRITY_REF_TAG. That way the
> block layer can remap the tags in its own copy.
Can avoid bouncing? I think the remapping flags can be tied to the
user's reftag check request.
If BIP_CHECK_REFTAG is set from the user setting IO_INTEGRITY_CHK_REFTAG
on a write, we can map the PI buffer for writing. The user explicitly
asked to have the ref tags checked by the device, and partitions require
remapping them, so they've told the kernel to write to their buffer.
And if the flag isn't set, blk_integrity_prepare() can skip the remap
for that bio because the request asked to not be checked.
next prev parent reply other threads:[~2026-11-20 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 15:40 Zakaria Belkadi
2026-11-19 22:44 ` Caleb Sander Mateos
2026-11-20 15:28 ` Christoph Hellwig
2026-11-20 16:22 ` Zakaria Belkadi
2026-11-20 16:58 ` Keith Busch [this message]
2026-11-20 17:13 ` Christoph Hellwig
2026-11-20 17:23 ` Keith Busch
2026-11-20 17:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awB8OODx0fCFGc5G@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=florence.schadle@ssi.gouv.fr \
--cc=frederic.tronel@centralesupelec.fr \
--cc=hch@infradead.org \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.rilling@irisa.fr \
--cc=stable@vger.kernel.org \
--cc=zakaria.belkadi@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®