mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Zakaria Belkadi <zakaria.belkadi@inria.fr>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kanchan Joshi <joshi.k@samsung.com>,
	Anuj Gupta <anuj20.g@samsung.com>,
	florence.schadle@ssi.gouv.fr, frederic.tronel@centralesupelec.fr,
	louis.rilling@irisa.fr, stable@vger.kernel.org
Subject: Re: [PATCH RESEND] block: pin user PI pages for writing when ref tags are remapped
Date: Fri, 20 Nov 2026 07:28:07 -0800	[thread overview]
Message-ID: <awBnB-55HQ54C1x6@infradead.org> (raw)
In-Reply-To: <20261118154053.13218-1-zakaria.belkadi@inria.fr>

On Wed, Nov 18, 2026 at 04:40:53PM +0100, Zakaria Belkadi wrote:
> +	/*
> +	 * blk_integrity_prepare() remaps the reference tags of a write in
> +	 * place, so the PI pages are written. Pin them for writing.
> +	 */
> +	if (bio_op(bio) == REQ_OP_WRITE && (bi->flags & BLK_INTEGRITY_REF_TAG))
> +		it.data_source = ITER_DEST;

I don't think we can just pin memory as writable that wasn't given to
us as writable.  So this needs to force bounce buffering, at least when
remapping might be required.


  parent reply	other threads:[~2026-11-20 15:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 15:40 Zakaria Belkadi
2026-11-19 22:44 ` Caleb Sander Mateos
2026-11-20 15:28 ` Christoph Hellwig [this message]
2026-11-20 16:22   ` Zakaria Belkadi
2026-11-20 16:58     ` Keith Busch
2026-11-20 17:13       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awBnB-55HQ54C1x6@infradead.org \
    --to=hch@infradead.org \
    --cc=anuj20.g@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=florence.schadle@ssi.gouv.fr \
    --cc=frederic.tronel@centralesupelec.fr \
    --cc=joshi.k@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.rilling@irisa.fr \
    --cc=stable@vger.kernel.org \
    --cc=zakaria.belkadi@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®