From: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
To: Rob Herring <robh@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Richard Cochran <richardcochran@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v4 03/10] dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible
Date: Sun, 22 Nov 2026 17:05:51 +0530 [thread overview]
Message-ID: <awLTl77S5Pj0Maok@oss.qualcomm.com> (raw)
In-Reply-To: <20261118190745.GA198891-robh@kernel.org>
On Wed, Nov 18, 2026 at 01:07:45PM -0600, Rob Herring wrote:
> On Tue, Nov 17, 2026 at 02:15:23PM +0530, Mohd Ayaan Anwar wrote:
> > Shikra's EMAC requires two additional clocks for NOC interconnect
> > access (axi-noc, pcie-tile-axi-noc) beyond the standard four, and an
> > OPP table with required-opps to vote VDD_CX to SVS when the NOC clocks
> > are enabled.
> >
> > Add qcom,shikra-ethqos to the compatible enum and use an if/else
> > block to constrain Shikra to exactly six clocks and require
> > operating-points-v2 and power-domains, while leaving existing
> > compatibles unchanged.
> >
> > Add the relevant compatible to the binding document for snps,dwmac as
> > well.
> >
> > Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
> > ---
> > v4: moved operating-points description to the top-level, and added
> > power-domains as a required property for Shikra.
> > ---
> > .../devicetree/bindings/net/qcom,ethqos.yaml | 54 ++++++++++++++++++++--
> > .../devicetree/bindings/net/snps,dwmac.yaml | 2 +
> > 2 files changed, 52 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> > index ef520f810577..6bd4bded650a 100644
> > --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> > +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> > @@ -14,9 +14,6 @@ description:
> > dwmmac based Qualcomm ethernet devices which support Gigabit
> > ethernet (version v2.3.0 and onwards).
> >
> > -allOf:
> > - - $ref: snps,dwmac.yaml#
> > -
> > properties:
> > compatible:
> > oneOf:
> > @@ -32,6 +29,7 @@ properties:
> > - qcom,qcs404-ethqos
> > - qcom,sa8775p-ethqos
> > - qcom,sc8280xp-ethqos
> > + - qcom,shikra-ethqos
> > - qcom,sm8150-ethqos
> >
> > reg:
> > @@ -57,9 +55,11 @@ properties:
> > - const: sfty
> >
> > clocks:
> > - maxItems: 4
> > + minItems: 4
> > + maxItems: 6
> >
> > clock-names:
> > + minItems: 4
> > items:
> > - const: stmmaceth
> > - const: pclk
> > @@ -67,6 +67,8 @@ properties:
> > - enum:
> > - rgmii
> > - phyaux
> > + - const: axi-noc
> > + - const: pcie-tile-axi-noc
>
> These sound like inter-connect clocks. Shouldn't they be controlled by
> a interconnect driver?
On other platforms, yes, the EMAC AXI clock is only a gate, and the
interconnect provider scales its rate along with the NoC.
However, on Shikra, the EMAC AXI path is fed by a dedicated GCC RCG:
gcc_emac0_axi_clk_src (RCG)
+- gcc_emac0_axi_clk "stmmaceth"
+- gcc_emac0_axi_sys_noc_clk "axi-noc"
+- gcc_pcie_tile_axi_sys_noc_clk "pcie-tile-axi-noc"
This RCG is outside the Shikra interconnect provider's control.
EMAC DMA does not work unless all three clocks stay enabled, so the
EMAC has to hold them and also scale their frequency for the line rate.
I am hoping that I understood your question correctly, please let me
know if you were asking something else.
> > ..
> >
> > +allOf:
> > + - $ref: snps,dwmac.yaml#
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: qcom,shikra-ethqos
> > + then:
> > + properties:
> > + clocks:
> > + minItems: 6
> > + clock-names:
> > + items:
> > + - const: stmmaceth
> > + - const: pclk
> > + - const: ptp_ref
> > + - const: rgmii
> > + - const: axi-noc
> > + - const: pcie-tile-axi-noc
>
> No need to repeat the names here. Just 'minItems: 6'. I suppose you
> might also want:
>
> contains:
> const: rgmii
Understood, I will make this change.
>
> > + required:
> > + - operating-points-v2
> > + - power-domains
> > + else:
> > + properties:
> > + clocks:
> > + maxItems: 4
> > + clock-names:
> > + items:
> > + - const: stmmaceth
> > + - const: pclk
> > + - const: ptp_ref
> > + - enum:
> > + - rgmii
> > + - phyaux
>
> Just 'minItems: 4'
>
I take it you meant 'maxItems: 4' here? If so, I will make that change
in the next revision.
Thank you for the review.
Ayaan
next prev parent reply other threads:[~2026-11-22 11:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 8:45 [PATCH net-next v4 00/10] net: stmmac: qcom-ethqos: add Shikra EMAC support Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 01/10] dt-bindings: net: ti,dp83867: add supply properties Mohd Ayaan Anwar
2026-11-18 18:58 ` Rob Herring (Arm)
2026-11-17 8:45 ` [PATCH net-next v4 02/10] net: phy: dp83867: add regulator supply management Mohd Ayaan Anwar
2026-11-20 11:45 ` netdev-bot+sashiko
2026-11-17 8:45 ` [PATCH net-next v4 03/10] dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible Mohd Ayaan Anwar
2026-11-18 19:07 ` Rob Herring
2026-11-22 11:35 ` Mohd Ayaan Anwar [this message]
2026-11-20 11:45 ` netdev-bot+sashiko
2026-11-17 8:45 ` [PATCH net-next v4 04/10] net: stmmac: qcom-ethqos: convert ethqos_rgmii_macro_init() to void Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 05/10] net: stmmac: qcom-ethqos: add DLL-bypass for PHY-managed RGMII delays Mohd Ayaan Anwar
2026-11-20 11:45 ` netdev-bot+sashiko
2026-11-22 11:31 ` Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 06/10] net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed Mohd Ayaan Anwar
2026-11-18 9:13 ` Lorenzo Bianconi
2026-11-17 8:45 ` [PATCH net-next v4 07/10] net: stmmac: qcom-ethqos: share common GMAC4 address table Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 08/10] net: stmmac: qcom-ethqos: add per-platform NOC clock voting Mohd Ayaan Anwar
2026-11-18 9:40 ` Lorenzo Bianconi
2026-11-17 8:45 ` [PATCH net-next v4 09/10] net: stmmac: qcom-ethqos: add Shikra EMAC support Mohd Ayaan Anwar
2026-11-18 9:43 ` Lorenzo Bianconi
2026-11-20 11:46 ` netdev-bot+sashiko
2026-11-17 8:45 ` [PATCH net-next v4 10/10] net: stmmac: qcom-ethqos: add QCS615 " Mohd Ayaan Anwar
2026-11-18 9:44 ` Lorenzo Bianconi
2026-11-20 11:46 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awLTl77S5Pj0Maok@oss.qualcomm.com \
--to=mohd.anwar@oss.qualcomm.com \
--cc=afd@ti.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®