mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] media: i2c: mira016: Fix analogue gain range for the default format
@ 2026-11-21 19:50 David Carlier
  2026-11-22 17:48 ` Jacopo Mondi
  0 siblings, 1 reply; 2+ messages in thread
From: David Carlier @ 2026-11-21 19:50 UTC (permalink / raw)
  To: jacopo.mondi, philippebaetens
  Cc: mchehab, linux-media, linux-kernel, David Carlier

The analogue gain control is created with a 1..1 range, and the range is
only updated when an active format is set. The default 8-bit format is
applied by init_state as a TRY format, so the gain cannot be changed
until userspace sets the active format.

Create the control with the 8-bit gain range to match the default format.

The issue was found by code inspection with an LLM, build tested only.

Fixes: ab4a4c39c611 ("media: i2c: mira016: Add driver for Mira016")
Signed-off-by: David Carlier <devnexen@gmail.com>
---
 drivers/media/i2c/mira016.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/mira016.c b/drivers/media/i2c/mira016.c
index 082442ffad28..076e8a22be82 100644
--- a/drivers/media/i2c/mira016.c
+++ b/drivers/media/i2c/mira016.c
@@ -1917,9 +1917,11 @@ static int mira016_init_controls(struct mira016 *mira016)
 					      MIRA016_MAX_EXPOSURE, 1,
 					      def_exposure);
 
+	/* The gain range matches the default 8-bit format set in init_state. */
 	mira016->gain = v4l2_ctrl_new_std(ctrl_hdlr, &mira016_ctrl_ops,
-					  V4L2_CID_ANALOGUE_GAIN,
-					  1, 1, 1, 1);
+					  V4L2_CID_ANALOGUE_GAIN, 1,
+					  ARRAY_SIZE(mira016_gain_lut_8bit),
+					  1, 1);
 
 	/*
 	 * Changing VFLIP requires re-programming the top point, hence we
-- 
2.55.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] media: i2c: mira016: Fix analogue gain range for the default format
  2026-11-21 19:50 [PATCH] media: i2c: mira016: Fix analogue gain range for the default format David Carlier
@ 2026-11-22 17:48 ` Jacopo Mondi
  0 siblings, 0 replies; 2+ messages in thread
From: Jacopo Mondi @ 2026-11-22 17:48 UTC (permalink / raw)
  To: David Carlier
  Cc: jacopo.mondi, philippebaetens, mchehab, linux-media, linux-kernel

Hi David

On Sat, Nov 21, 2026 at 07:50:10PM +0000, David Carlier wrote:
> The analogue gain control is created with a 1..1 range, and the range is
> only updated when an active format is set. The default 8-bit format is
> applied by init_state as a TRY format, so the gain cannot be changed
> until userspace sets the active format.
>
> Create the control with the 8-bit gain range to match the default format.

I'm surprised I used the 8-bits format as default. I thought it was 12
and clearly overlooked it.

Honestly, I would use the 12 bits format as a default as higher
bitdepths are maybe preferable ?

>
> The issue was found by code inspection with an LLM, build tested only.
>
> Fixes: ab4a4c39c611 ("media: i2c: mira016: Add driver for Mira016")

Do we need one ? The driver didn't land in any published kernel yet.


> Signed-off-by: David Carlier <devnexen@gmail.com>
> ---
>  drivers/media/i2c/mira016.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/mira016.c b/drivers/media/i2c/mira016.c
> index 082442ffad28..076e8a22be82 100644
> --- a/drivers/media/i2c/mira016.c
> +++ b/drivers/media/i2c/mira016.c
> @@ -1917,9 +1917,11 @@ static int mira016_init_controls(struct mira016 *mira016)
>  					      MIRA016_MAX_EXPOSURE, 1,
>  					      def_exposure);
>
> +	/* The gain range matches the default 8-bit format set in init_state. */
>  	mira016->gain = v4l2_ctrl_new_std(ctrl_hdlr, &mira016_ctrl_ops,
> -					  V4L2_CID_ANALOGUE_GAIN,
> -					  1, 1, 1, 1);
> +					  V4L2_CID_ANALOGUE_GAIN, 1,
> +					  ARRAY_SIZE(mira016_gain_lut_8bit),
> +					  1, 1);
>
>  	/*
>  	 * Changing VFLIP requires re-programming the top point, hence we
> --
> 2.55.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-22 17:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-21 19:50 [PATCH] media: i2c: mira016: Fix analogue gain range for the default format David Carlier
2026-11-22 17:48 ` Jacopo Mondi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®