mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alexander A. Klimov" <grandmaster@al2klimov.de>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@chromium.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Shuah Khan <shuah@kernel.org>,
	Stanislav Fomichev <sdf@google.com>,
	Quentin Monnet <quentin@isovalent.com>,
	Andrey Ignatov <rdna@fb.com>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	Network Development <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>,
	Clang-Built-Linux ML <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: BPF (Safe dynamic programs and tools)
Date: Fri, 3 Jul 2020 08:38:52 +0200	[thread overview]
Message-ID: <b06e1efb-b2e6-b06b-bf24-1369c42e8ace@al2klimov.de> (raw)
In-Reply-To: <CAADnVQKaL7cX2oCFLU7MW+CMf4ySbJf3tC3YqajDxgbuPCY-Cg@mail.gmail.com>



Am 03.07.20 um 00:08 schrieb Alexei Starovoitov:
> On Thu, Jul 2, 2020 at 1:05 PM Alexander A. Klimov
> <grandmaster@al2klimov.de> wrote:
>>
>> Rationale:
>> Reduces attack surface on kernel devs opening the links for MITM
>> as HTTPS traffic is much harder to manipulate.
>>
>> Deterministic algorithm:
>> For each file:
>>    If not .svg:
>>      For each line:
>>        If doesn't contain `\bxmlns\b`:
>>          For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>>            If both the HTTP and HTTPS versions
>>            return 200 OK and serve the same content:
>>              Replace HTTP with HTTPS.
>>
>> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
>> ---
>>   Continuing my work started at 93431e0607e5.
>>
>>   If there are any URLs to be removed completely or at least not HTTPSified:
>>   Just clearly say so and I'll *undo my change*.
>>   See also https://lkml.org/lkml/2020/6/27/64
>>
>>   If there are any valid, but yet not changed URLs:
>>   See https://lkml.org/lkml/2020/6/26/837
>>
>>   Documentation/bpf/bpf_devel_QA.rst          | 4 ++--
>>   Documentation/bpf/index.rst                 | 2 +-
>>   Documentation/networking/af_xdp.rst         | 2 +-
>>   Documentation/networking/filter.rst         | 2 +-
>>   arch/x86/net/bpf_jit_comp.c                 | 2 +-
>>   include/linux/bpf.h                         | 2 +-
>>   include/linux/bpf_verifier.h                | 2 +-
>>   include/uapi/linux/bpf.h                    | 2 +-
>>   kernel/bpf/arraymap.c                       | 2 +-
>>   kernel/bpf/core.c                           | 2 +-
>>   kernel/bpf/disasm.c                         | 2 +-
>>   kernel/bpf/disasm.h                         | 2 +-
>>   kernel/bpf/hashtab.c                        | 2 +-
>>   kernel/bpf/helpers.c                        | 2 +-
>>   kernel/bpf/syscall.c                        | 2 +-
>>   kernel/bpf/verifier.c                       | 2 +-
>>   kernel/trace/bpf_trace.c                    | 2 +-
>>   lib/test_bpf.c                              | 2 +-
>>   net/core/filter.c                           | 2 +-
>>   samples/bpf/lathist_kern.c                  | 2 +-
>>   samples/bpf/lathist_user.c                  | 2 +-
>>   samples/bpf/sockex3_kern.c                  | 2 +-
>>   samples/bpf/tracex1_kern.c                  | 2 +-
>>   samples/bpf/tracex2_kern.c                  | 2 +-
>>   samples/bpf/tracex3_kern.c                  | 2 +-
>>   samples/bpf/tracex3_user.c                  | 2 +-
>>   samples/bpf/tracex4_kern.c                  | 2 +-
>>   samples/bpf/tracex4_user.c                  | 2 +-
>>   samples/bpf/tracex5_kern.c                  | 2 +-
>>   tools/include/uapi/linux/bpf.h              | 2 +-
>>   tools/lib/bpf/bpf.c                         | 2 +-
>>   tools/lib/bpf/bpf.h                         | 2 +-
>>   tools/testing/selftests/bpf/test_maps.c     | 2 +-
>>   tools/testing/selftests/bpf/test_verifier.c | 2 +-
>>   34 files changed, 35 insertions(+), 35 deletions(-)
> 
> Nacked-by: Alexei Starovoitov <ast@kernel.org>
> 
> Pls don't touch anything bpf related with such changes.
https://lore.kernel.org/linux-doc/20200526060544.25127-1-grandmaster@al2klimov.de/
– merged.

https://lore.kernel.org/linux-doc/20200608181649.74883-1-grandmaster@al2klimov.de/
– applied.

https://lore.kernel.org/linux-doc/20200620075402.22347-1-grandmaster@al2klimov.de/
– applied.

https://lore.kernel.org/linux-doc/20200621133512.46311-1-grandmaster@al2klimov.de/
– applied.

https://lore.kernel.org/linux-doc/20200621133552.46371-1-grandmaster@al2klimov.de/
– applied.

https://lore.kernel.org/linux-doc/20200621133630.46435-1-grandmaster@al2klimov.de/
– applied.

https://lore.kernel.org/linux-doc/20200627103050.71712-1-grandmaster@al2klimov.de/
– applied.

https://lore.kernel.org/linux-doc/20200627103125.71828-1-grandmaster@al2klimov.de/
– reviewed.

https://lore.kernel.org/linux-doc/20200627103151.71942-1-grandmaster@al2klimov.de/
– reviewed.

This one – no, pls not.

Why exactly not? Are these URLs not being opened at all (What they're 
doing there then?) or have all who open them the HTTPS everywhere 
browser addon installed?

> 

      reply	other threads:[~2020-07-03  6:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 20:05 Alexander A. Klimov
2020-07-02 22:08 ` Alexei Starovoitov
2020-07-03  6:38   ` Alexander A. Klimov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b06e1efb-b2e6-b06b-bf24-1369c42e8ace@al2klimov.de \
    --to=grandmaster@al2klimov.de \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bp@alien8.de \
    --cc=bpf@vger.kernel.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=hpa@zytor.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@chromium.org \
    --cc=kuba@kernel.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=quentin@isovalent.com \
    --cc=rdna@fb.com \
    --cc=rostedt@goodmis.org \
    --cc=sdf@google.com \
    --cc=shuah@kernel.org \
    --cc=songliubraving@fb.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yhs@fb.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®