mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Michal Piotrowski" <michal.k.k.piotrowski@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/10] Kernel memory leak detector 0.8
Date: Wed, 12 Jul 2006 15:37:15 +0100	[thread overview]
Message-ID: <b0943d9e0607120737h691212ddl31d5db4bb1cb3db4@mail.gmail.com> (raw)
In-Reply-To: <6bffcb0e0607120619p6837a64bice7808856f93b11b@mail.gmail.com>

On 12/07/06, Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:
> Here is a slabinfo from current 2.6.18-rc1-git4 and 2.6.18-rc1 +
> kmemleak http://www.stardust.webpages.pl/files/o_bugs/kml/slab.txt

Thanks. Does it make any difference if you enable
CONFIG_DEBUG_MEMLEAK_TASK_STACKS? Also, if you save the memleak file
periodically, do any of the context_struct_to_string reports disappear
(I can investigate this if you upload a few ml60.txt, mk61.txt etc.)?

> I haven't seen that before
> orphan pointer 0xf1283e34 (size 224):
>   c01735c2: <kmem_cache_alloc>
>   fdc8c5cf: <ip_conntrack_alloc>
>   fdc8c6a3: <init_conntrack>
>   fdc8c894: <ip_conntrack_in>
>   fdc8b652: <ip_conntrack_local>
>   c02c15bf: <nf_iterate>
>   c02c1630: <nf_hook_slow>
>   c02e127e: <raw_send_hdrinc>

This looks like a false positive as the conntrack pointer is lost in
init_conntrack and only a pointer conntrack->tuplehash[...].list is
stored. This cannot be aliased via container_of because
tuplehash_to_ctrack doesn't pass a constant argument to it and cannot
be determined at compile time. Try the attached patch.

Note that you can get some false positives that might disappear after
a while. This is because of the stacks scanning and also pointers
stored in CPU registers, especially on SMP systems.

Thanks.

-- 
Catalin

  reply	other threads:[~2006-07-12 14:37 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-10 22:09 Catalin Marinas
2006-07-10 22:09 ` [PATCH 01/10] Base support for kmemleak Catalin Marinas
2006-07-10 22:09 ` [PATCH 02/10] Some documentation " Catalin Marinas
2006-07-10 22:09 ` [PATCH 03/10] Add the memory allocation/freeing hooks " Catalin Marinas
2006-07-11  6:17   ` Pekka Enberg
2006-07-11  7:59     ` Catalin Marinas
2006-07-10 22:10 ` [PATCH 04/10] Modules support " Catalin Marinas
2006-07-10 22:10 ` [PATCH 05/10] Add kmemleak support for i386 Catalin Marinas
2006-07-10 22:10 ` [PATCH 06/10] Add kmemleak support for ARM Catalin Marinas
2006-07-10 22:10 ` [PATCH 07/10] Remove some of the kmemleak false positives Catalin Marinas
2006-07-11  6:49   ` Pekka Enberg
2006-07-11  8:18     ` Catalin Marinas
2006-07-10 22:10 ` [PATCH 08/10] Keep the __init functions after initialization Catalin Marinas
2006-07-10 22:10 ` [PATCH 09/10] Simple testing for kmemleak Catalin Marinas
2006-07-10 22:11 ` [PATCH 10/10] Update the MAINTAINERS file " Catalin Marinas
2006-07-11 12:27 ` [PATCH 00/10] Kernel memory leak detector 0.8 Michal Piotrowski
2006-07-11 12:46   ` Michal Piotrowski
2006-07-11 12:51     ` Michal Piotrowski
2006-07-11 13:00       ` Catalin Marinas
2006-07-11 13:09         ` Michal Piotrowski
2006-07-12  9:57         ` Joseph Fannin
2006-07-12 10:38           ` Catalin Marinas
2006-07-12 10:49             ` Michal Piotrowski
2006-07-14  2:22             ` Horst von Brand
2006-07-11 12:56   ` Catalin Marinas
2006-07-11 13:17     ` Michal Piotrowski
2006-07-11 13:28       ` Catalin Marinas
2006-07-11 13:49         ` Michal Piotrowski
2006-07-11 14:02           ` Catalin Marinas
2006-07-11 15:02             ` Michal Piotrowski
2006-07-11 15:44               ` Catalin Marinas
2006-07-11 16:02                 ` Michal Piotrowski
2006-07-11 16:31                   ` Catalin Marinas
2006-07-11 17:00                     ` Michal Piotrowski
2006-07-11 21:54                       ` Catalin Marinas
2006-07-12 11:35                         ` Michal Piotrowski
2006-07-12 16:17                           ` Catalin Marinas
2006-07-12 22:55                             ` Michal Piotrowski
2006-07-13 16:35                               ` Catalin Marinas
2006-07-13 19:14                                 ` Michal Piotrowski
2006-07-14 14:53                                   ` Catalin Marinas
2006-07-12 13:19                         ` Michal Piotrowski
2006-07-12 14:37                           ` Catalin Marinas [this message]
2006-07-12 15:33                             ` Michal Piotrowski
2006-07-12 16:12                               ` Catalin Marinas
2006-07-12 10:33               ` Catalin Marinas
2006-07-12 18:46                 ` Xiaolan Zhang
2006-07-13 18:52                 ` Xiaolan Zhang
2006-07-13 19:17                   ` Michal Piotrowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0943d9e0607120737h691212ddl31d5db4bb1cb3db4@mail.gmail.com \
    --to=catalin.marinas@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®