* [PATCH v4 1/1] scsi: ufs: core: Add support to notify userspace of UniPro QoS events
[not found] <20260305110856.959211-1-can.guo@oss.qualcomm.com>
@ 2026-03-05 11:08 ` Can Guo
2026-03-05 12:30 ` Bart Van Assche
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Can Guo @ 2026-03-05 11:08 UTC (permalink / raw)
To: avri.altman, bvanassche, beanhuo, martin.petersen
Cc: linux-scsi, Can Guo, Alim Akhtar, James E.J. Bottomley,
Peter Wang, Huan Tang, Lu Hongfei, Bao D. Nguyen, Yangtao Li,
Keoseong Park, Zhongqiu Han, Liu Song, Ram Kumar Dwivedi,
Daniel Lee, Bean Huo, Adrian Hunter, open list
The UniPro stack manages to repair many potential Link problems without the
need to notify the Application Layer. Repair mechanisms of the stack
include L2 re-transmission and successful handling of PA_INIT.req.
Nevertheless, any successful repair sequence requires Link bandwidth that
is no longer vailable for the Application. Therefore, it may be useful for
an Application to understand how often such repair attempts are made.
The DME implements Quality of Service monitoring using a simple counting
scheme, counting error events and comparing them against the number of
correctly received or transmitted bytes. When the error counter exceeds a
programmed threshold before the byte counter overflows, a DME_QoS.ind is
issued to the Application and both counters are reset. When the byte
counter overflows before the error counter has reached the programmed
threshold, both counters are reset without triggering a DME_QoS.ind.
The DME provides Link quality monitoring for the following purposes:
1. Detection of re-occurring repaired fatal error conditions on the Link
(PA_INIT loop). This kind of detection is useful if capabilities
exchanged between local and peer permit a potential operation at a
higher M-PHY Gear, but the physical interconnect between local and peer
Device does not, or, after Line quality degradation, no longer satisfies
channel characteristics.
2. Detection of degraded inbound or outbound Link quality, to allow an
Application to issue an ADAPT sequence for a Link running in HS-G4 or
higher HS Gears. This kind of detection is used to monitor a slowly
degrading Link quality, e.g., one being affected by temperature and
voltage variations, against the expected M-PHY bit error rate.
Userspace can configure and enable UniPro QoS via UniPro QoS Attributes
(via UFS BSG) and get notified by dme_qos_notification without polling
UniPro QoS Status attribute. The dme_qos_notification attribute is a
bitfield with the following bit assignments:
Bit Description
=== ======================================
0 DME QoS Monitor has been reset by host
1 QoS from TX is detected
2 QoS from RX is detected
3 QoS from PA_INIT is detected
Signed-off-by: Can Guo <can.guo@oss.qualcomm.com>
---
Documentation/ABI/testing/sysfs-driver-ufs | 23 +++++++++++++++++
drivers/ufs/core/ufs-sysfs.c | 30 ++++++++++++++++++++++
drivers/ufs/core/ufshcd.c | 24 ++++++++++++++---
include/ufs/ufshcd.h | 9 +++++++
include/ufs/ufshci.h | 1 +
5 files changed, 84 insertions(+), 3 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-driver-ufs b/Documentation/ABI/testing/sysfs-driver-ufs
index a90612ab5780..3c422aac778b 100644
--- a/Documentation/ABI/testing/sysfs-driver-ufs
+++ b/Documentation/ABI/testing/sysfs-driver-ufs
@@ -1768,3 +1768,26 @@ Description:
==================== ===========================
The attribute is read only.
+
+What: /sys/bus/platform/drivers/ufshcd/*/dme_qos_notification
+What: /sys/bus/platform/devices/*.ufs/dme_qos_notification
+Date: March 2026
+Contact: Can Guo <can.guo@oss.qualcomm.com>
+Description:
+ This attribute reports and clears pending DME (Device Management
+ Entity) Quality of Service (QoS) notifications. This attribute
+ is a bitfield with the following bit assignments:
+
+ Bit Description
+ === ======================================
+ 0 DME QoS Monitor has been reset by host
+ 1 QoS from TX is detected
+ 2 QoS from RX is detected
+ 3 QoS from PA_INIT is detected
+
+ Reading this attribute returns the pending DME QoS notification
+ bits. Writing '0' to this attribute clears pending DME QoS
+ notification bits. Writing any non-zero value is invalid and
+ will be rejected.
+
+ The attribute is read/write.
diff --git a/drivers/ufs/core/ufs-sysfs.c b/drivers/ufs/core/ufs-sysfs.c
index 384d958615d7..99af3c73f1af 100644
--- a/drivers/ufs/core/ufs-sysfs.c
+++ b/drivers/ufs/core/ufs-sysfs.c
@@ -605,6 +605,34 @@ static ssize_t device_lvl_exception_id_show(struct device *dev,
return sysfs_emit(buf, "%llu\n", exception_id);
}
+static ssize_t dme_qos_notification_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct ufs_hba *hba = dev_get_drvdata(dev);
+
+ return sysfs_emit(buf, "0x%x\n", atomic_read(&hba->dme_qos_notification));
+}
+
+static ssize_t dme_qos_notification_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ struct ufs_hba *hba = dev_get_drvdata(dev);
+ unsigned int value;
+
+ if (kstrtouint(buf, 0, &value))
+ return -EINVAL;
+
+ /* the only supported usecase is to reset the dme_qos_notification */
+ if (value)
+ return -EINVAL;
+
+ atomic_set(&hba->dme_qos_notification, 0);
+
+ return count;
+}
+
static DEVICE_ATTR_RW(rpm_lvl);
static DEVICE_ATTR_RO(rpm_target_dev_state);
static DEVICE_ATTR_RO(rpm_target_link_state);
@@ -621,6 +649,7 @@ static DEVICE_ATTR_RW(pm_qos_enable);
static DEVICE_ATTR_RO(critical_health);
static DEVICE_ATTR_RW(device_lvl_exception_count);
static DEVICE_ATTR_RO(device_lvl_exception_id);
+static DEVICE_ATTR_RW(dme_qos_notification);
static struct attribute *ufs_sysfs_ufshcd_attrs[] = {
&dev_attr_rpm_lvl.attr,
@@ -639,6 +668,7 @@ static struct attribute *ufs_sysfs_ufshcd_attrs[] = {
&dev_attr_critical_health.attr,
&dev_attr_device_lvl_exception_count.attr,
&dev_attr_device_lvl_exception_id.attr,
+ &dev_attr_dme_qos_notification.attr,
NULL
};
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 8349fe2090db..ccd9cf228210 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -6962,10 +6962,19 @@ static irqreturn_t ufshcd_update_uic_error(struct ufs_hba *hba)
}
reg = ufshcd_readl(hba, REG_UIC_ERROR_CODE_DME);
- if ((reg & UIC_DME_ERROR) &&
- (reg & UIC_DME_ERROR_CODE_MASK)) {
+ if (reg & UIC_DME_ERROR) {
ufshcd_update_evt_hist(hba, UFS_EVT_DME_ERR, reg);
- hba->uic_error |= UFSHCD_UIC_DME_ERROR;
+
+ if (reg & UIC_DME_ERROR_CODE_MASK)
+ hba->uic_error |= UFSHCD_UIC_DME_ERROR;
+
+ if (reg & UIC_DME_QOS_MASK) {
+ atomic_set(&hba->dme_qos_notification,
+ reg & UIC_DME_QOS_MASK);
+ if (hba->dme_qos_sysfs_handle)
+ sysfs_notify_dirent(hba->dme_qos_sysfs_handle);
+ }
+
retval |= IRQ_HANDLED;
}
@@ -9097,6 +9106,12 @@ static int ufshcd_post_device_init(struct ufs_hba *hba)
/* UFS device is also active now */
ufshcd_set_ufs_dev_active(hba);
+
+ /* Indicate that DME QoS Monitor has been reset */
+ atomic_set(&hba->dme_qos_notification, 0x1);
+ if (hba->dme_qos_sysfs_handle)
+ sysfs_notify_dirent(hba->dme_qos_sysfs_handle);
+
ufshcd_force_reset_auto_bkops(hba);
ufshcd_set_timestamp_attr(hba);
@@ -9729,6 +9744,7 @@ static void ufshcd_hba_exit(struct ufs_hba *hba)
hba->is_powered = false;
ufs_put_device_desc(hba);
}
+ sysfs_put(hba->dme_qos_sysfs_handle);
}
static int ufshcd_execute_start_stop(struct scsi_device *sdev,
@@ -11044,6 +11060,8 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
goto out_disable;
ufs_sysfs_add_nodes(hba->dev);
+ hba->dme_qos_sysfs_handle = sysfs_get_dirent(hba->dev->kobj.sd,
+ "dme_qos_notification");
async_schedule(ufshcd_async_scan, hba);
device_enable_async_suspend(dev);
diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
index 8563b6648976..182f301c11e7 100644
--- a/include/ufs/ufshcd.h
+++ b/include/ufs/ufshcd.h
@@ -943,6 +943,11 @@ enum ufshcd_mcq_opr {
* @critical_health_count: count of critical health exceptions
* @dev_lvl_exception_count: count of device level exceptions since last reset
* @dev_lvl_exception_id: vendor specific information about the device level exception event.
+ * @dme_qos_notification: Bitfield of pending DME Quality of Service (QoS)
+ * events. Bits[3:1] reflect the corresponding bits of UIC DME Error Code
+ * field within the Host Controller's UECDME register. Bit[0] is a flag
+ * indicating that the DME QoS Monitor has been reset by the host.
+ * @dme_qos_sysfs_handle: handle for 'dme_qos_notification' sysfs entry
* @rpmbs: list of OP-TEE RPMB devices (one per RPMB region)
*/
struct ufs_hba {
@@ -1116,6 +1121,10 @@ struct ufs_hba {
int critical_health_count;
atomic_t dev_lvl_exception_count;
u64 dev_lvl_exception_id;
+
+ atomic_t dme_qos_notification;
+ struct kernfs_node *dme_qos_sysfs_handle;
+
u32 vcc_off_delay_us;
struct list_head rpmbs;
};
diff --git a/include/ufs/ufshci.h b/include/ufs/ufshci.h
index 806fdaf52bd9..49a3a279e448 100644
--- a/include/ufs/ufshci.h
+++ b/include/ufs/ufshci.h
@@ -271,6 +271,7 @@ enum {
/* UECDME - Host UIC Error Code DME 48h */
#define UIC_DME_ERROR 0x80000000
#define UIC_DME_ERROR_CODE_MASK 0x1
+#define UIC_DME_QOS_MASK 0xE
/* UTRIACR - Interrupt Aggregation control register - 0x4Ch */
#define INT_AGGR_TIMEOUT_VAL_MASK 0xFF
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread