From: Atish Patra <Atish.Patra@wdc.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: "anup@brainfault.org" <anup@brainfault.org>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"palmer@sifive.com" <palmer@sifive.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"johan@kernel.org" <johan@kernel.org>
Subject: Re: [v6 PATCH] RISC-V: Remove unsupported isa string info print
Date: Tue, 1 Oct 2019 08:22:37 +0000 [thread overview]
Message-ID: <b0c39a9895698d74e2f44eb1f2faed46eee54bc3.camel@wdc.com> (raw)
In-Reply-To: <20191001070236.GA7622@infradead.org>
On Tue, 2019-10-01 at 00:02 -0700, Christoph Hellwig wrote:
> On Mon, Sep 30, 2019 at 05:23:18PM -0700, Atish Patra wrote:
> > /proc/cpuinfo should just print all the isa string as an
> > information
> > instead of determining what is supported or not. ELF hwcap can be
> > used by the userspace to figure out that.
> >
> > Simplify the isa string printing by removing the unsupported isa
> > string
> > print and all related code.
> >
> > The relevant discussion can be found at
> > http://lists.infradead.org/pipermail/linux-riscv/2019-September/006702.html
>
> This looks good, but can you also rename the orig_isa argument to isa
> now that we never modify it?
>
Sure. I will do that.
> > /*
> > * Linux doesn't support rv32e or rv128i, and we only support
> > booting
> > * kernels on harts with the same ISA that the kernel is
> > compiled for.
> > */
> > #if defined(CONFIG_32BIT)
> > - if (strncmp(isa, "rv32i", 5) != 0)
> > + if (strncmp(orig_isa, "rv32i", 5) != 0)
> > return;
> > #elif defined(CONFIG_64BIT)
> > - if (strncmp(isa, "rv64i", 5) != 0)
> > + if (strncmp(orig_isa, "rv64i", 5) != 0)
> > return;
> > #endif
>
> And I don't think having these checks here makes much sense.
Correct. As we are dumping the isa information as it is, we should get
rid of these checks as well.
> If we want
> to check this at all we should do it somewhere in the boot process.
riscv_of_processor_hartid() or seems to be a better candidate. We
already check if "rv" is present in isa string or not. I will extend
that to check for rv64i or rv32i. Is that okay ?
--
Regards,
Atish
next prev parent reply other threads:[~2019-10-01 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 0:23 Atish Patra
2019-10-01 7:02 ` Christoph Hellwig
2019-10-01 8:22 ` Atish Patra [this message]
2019-10-01 10:10 ` hch
2019-10-02 1:53 ` Alan Kao
2019-10-02 6:28 ` Atish Patra
2019-10-07 16:58 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0c39a9895698d74e2f44eb1f2faed46eee54bc3.camel@wdc.com \
--to=atish.patra@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=hch@infradead.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®