From: Atish Patra <Atish.Patra@wdc.com>
To: "hch@infradead.org" <hch@infradead.org>,
"alankao@andestech.com" <alankao@andestech.com>
Cc: "anup@brainfault.org" <anup@brainfault.org>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"palmer@sifive.com" <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"johan@kernel.org" <johan@kernel.org>
Subject: Re: [v6 PATCH] RISC-V: Remove unsupported isa string info print
Date: Wed, 2 Oct 2019 06:28:59 +0000 [thread overview]
Message-ID: <bc0d2f2803950ebb38fd487fddb0fcf8a370512e.camel@wdc.com> (raw)
In-Reply-To: <20191002015338.GA28086@andestech.com>
On Wed, 2019-10-02 at 09:53 +0800, Alan Kao wrote:
> On Tue, Oct 01, 2019 at 03:10:16AM -0700, hch@infradead.org wrote:
> > On Tue, Oct 01, 2019 at 08:22:37AM +0000, Atish Patra wrote:
> > > riscv_of_processor_hartid() or seems to be a better candidate. We
> > > already check if "rv" is present in isa string or not. I will
> > > extend
> > > that to check for rv64i or rv32i. Is that okay ?
> >
> > I'd rather lift the checks out of that into a function that is
> > called
> > exactly once per hart on boot (and future cpu hotplug).
>
@Christoph
Do you mean to lift the checks for "rv" as well from
riscv_of_processor_hartid as well or leave that as it is?
> Sorry that I am a bit out of date on this. Is there any related
> discussion about such checks?
We are trying to remove all the checks in /proc/cpuinfo and just print
isa as it is. Here is the previous discussion.
http://lists.infradead.org/pipermail/linux-riscv/2019-
September/006702.html
> Just want to make sure if the check
> stops here and will not go any further for extensions, Xs and Zs.
>
At least not here. I don't think we need to check for optional
extensions anywhere except in the extension relevant code.
> > _______________________________________________
> > linux-riscv mailing list
> > linux-riscv@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-riscv
--
Regards,
Atish
next prev parent reply other threads:[~2019-10-02 6:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 0:23 Atish Patra
2019-10-01 7:02 ` Christoph Hellwig
2019-10-01 8:22 ` Atish Patra
2019-10-01 10:10 ` hch
2019-10-02 1:53 ` Alan Kao
2019-10-02 6:28 ` Atish Patra [this message]
2019-10-07 16:58 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc0d2f2803950ebb38fd487fddb0fcf8a370512e.camel@wdc.com \
--to=atish.patra@wdc.com \
--cc=alankao@andestech.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=hch@infradead.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®