* [PATCH] fs/ntfs3: update ctime only on successful setxattr
@ 2026-06-26 9:49 Baolin Liu
2026-09-14 7:35 ` Konstantin Komarov
0 siblings, 1 reply; 2+ messages in thread
From: Baolin Liu @ 2026-06-26 9:49 UTC (permalink / raw)
To: almaz.alexandrovich; +Cc: ntfs3, linux-kernel, liubaolin12138, Baolin Liu
From: Baolin Liu <liubaolin@kylinos.cn>
ntfs_setxattr() updates ctime and marks the inode dirty even when the
xattr operation fails.
Do that only on success.
Fixes: 2d44667c306e ("fs/ntfs3: Update i_ctime when xattr is added")
Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
---
fs/ntfs3/xattr.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c
index 9eeac0ab2b71..9743a63a152e 100644
--- a/fs/ntfs3/xattr.c
+++ b/fs/ntfs3/xattr.c
@@ -960,8 +960,10 @@ static noinline int ntfs_setxattr(const struct xattr_handler *handler,
NULL);
out:
- inode_set_ctime_current(inode);
- mark_inode_dirty(inode);
+ if (!err) {
+ inode_set_ctime_current(inode);
+ mark_inode_dirty(inode);
+ }
return err;
}
--
2.51.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] fs/ntfs3: update ctime only on successful setxattr
2026-06-26 9:49 [PATCH] fs/ntfs3: update ctime only on successful setxattr Baolin Liu
@ 2026-09-14 7:35 ` Konstantin Komarov
0 siblings, 0 replies; 2+ messages in thread
From: Konstantin Komarov @ 2026-09-14 7:35 UTC (permalink / raw)
To: Baolin Liu; +Cc: ntfs3, linux-kernel, Baolin Liu
On 6/26/26 11:49, Baolin Liu wrote:
> From: Baolin Liu <liubaolin@kylinos.cn>
>
> ntfs_setxattr() updates ctime and marks the inode dirty even when the
> xattr operation fails.
>
> Do that only on success.
>
> Fixes: 2d44667c306e ("fs/ntfs3: Update i_ctime when xattr is added")
> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
> ---
> fs/ntfs3/xattr.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c
> index 9eeac0ab2b71..9743a63a152e 100644
> --- a/fs/ntfs3/xattr.c
> +++ b/fs/ntfs3/xattr.c
> @@ -960,8 +960,10 @@ static noinline int ntfs_setxattr(const struct xattr_handler *handler,
> NULL);
>
> out:
> - inode_set_ctime_current(inode);
> - mark_inode_dirty(inode);
> + if (!err) {
> + inode_set_ctime_current(inode);
> + mark_inode_dirty(inode);
> + }
>
> return err;
> }
Hello,
Sorry for the delay.
Your patch is applied, thanks.
Regards,
Konstantin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-14 7:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-26 9:49 [PATCH] fs/ntfs3: update ctime only on successful setxattr Baolin Liu
2026-09-14 7:35 ` Konstantin Komarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®