From: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
To: Ruslan Koreev <koreev.r@gmail.com>,
<sakari.ailus@linux.intel.com>, <sylvain.petinot@foss.st.com>,
<dan.scally@ideasonboard.com>
Cc: <mchehab@kernel.org>, <hansg@kernel.org>,
<ilpo.jarvinen@linux.intel.com>, <linux-media@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Peter Marshall <pm@petermarshall.ca>
Subject: Re: [PATCH v2 4/4] media: i2c: vd55g1: Add ACPI support
Date: Wed, 30 Sep 2026 09:58:01 +0200 [thread overview]
Message-ID: <b0e2f1d3-b22a-458e-9316-636b7dbcca79@foss.st.com> (raw)
In-Reply-To: <20260929092700.1776966-6-koreev.r@gmail.com>
Hi Ruslan,
Le 29/09/2026 à 11:27, Ruslan Koreev a écrit :
> Add an ACPI match table with the TBE20A1 HID that Lenovo uses for the
> VD55G1, with the same match data as the st,vd55g1 compatible.
>
> Signed-off-by: Ruslan Koreev <koreev.r@gmail.com>
Again, can't test but :
Acked-By: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
> drivers/media/i2c/vd55g1.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
> index 8043eaa50..e3939bb9b 100644
> --- a/drivers/media/i2c/vd55g1.c
> +++ b/drivers/media/i2c/vd55g1.c
> @@ -2081,6 +2081,12 @@ static const struct of_device_id vd55g1_dt_ids[] = {
> };
> MODULE_DEVICE_TABLE(of, vd55g1_dt_ids);
>
> +static const struct acpi_device_id vd55g1_acpi_ids[] = {
> + { .id = "TBE20A1", .driver_data = (kernel_ulong_t)&vd55g1_versions[0] },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(acpi, vd55g1_acpi_ids);
> +
> static const struct dev_pm_ops vd55g1_pm_ops = {
> SET_RUNTIME_PM_OPS(vd55g1_power_off, vd55g1_power_on, NULL)
> };
> @@ -2089,6 +2095,7 @@ static struct i2c_driver vd55g1_i2c_driver = {
> .driver = {
> .name = "vd55g1",
> .of_match_table = vd55g1_dt_ids,
> + .acpi_match_table = vd55g1_acpi_ids,
> .pm = &vd55g1_pm_ops,
> },
> .probe = vd55g1_probe,
--
Regards,
Benjamin
prev parent reply other threads:[~2026-09-30 7:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 9:26 [PATCH v2 0/4] Lenovo ThinkPad X1 Carbon Gen 14 IR camera: ST VD55G1 on Intel IPU7 Ruslan Koreev
2026-09-29 9:26 ` [PATCH v2 1/4] platform/x86: int3472: Map the VD55G1 power enable GPIO to "vana" Ruslan Koreev
2026-09-29 9:26 ` [PATCH v2 2/4] media: ipu-bridge: Add the ST VD55G1 (TBE20A1) Ruslan Koreev
2026-09-29 9:27 ` [PATCH v2 3/4] media: i2c: vd55g1: Return the endpoint parser's error code Ruslan Koreev
2026-09-30 7:57 ` Benjamin Mugnier
2026-09-29 9:27 ` [PATCH v2 4/4] media: i2c: vd55g1: Add ACPI support Ruslan Koreev
2026-09-30 7:58 ` Benjamin Mugnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0e2f1d3-b22a-458e-9316-636b7dbcca79@foss.st.com \
--to=benjamin.mugnier@foss.st.com \
--cc=dan.scally@ideasonboard.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=koreev.r@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pm@petermarshall.ca \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®