mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Viacheslav Dubeyko <vdubeyko@redhat.com>
To: Colin Ian King <colin.i.king@gmail.com>,
	Viacheslav Dubeyko	 <slava@dubeyko.com>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	 Yangtao Li <frank.li@vivo.com>,
	linux-fsdevel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hfsplus: remove xattr error message
Date: Mon, 13 Apr 2026 10:12:13 -0700	[thread overview]
Message-ID: <b0e9b8218a2daeb65c8481d1f4646f3ca89d713a.camel@redhat.com> (raw)
In-Reply-To: <20260411125338.165758-1-colin.i.king@gmail.com>

On Sat, 2026-04-11 at 13:53 +0100, Colin Ian King wrote:
> When exercising hfsplus with the stress-ng xattr stressor a large
> quantity of somewhat unhelpful error messages "hfsplus: xattr exists
> yet" spam the kernel log. Remove these.

We can convert it into hfs_dbg() and to add showing inode ID + name. What do you
think?

Also, there are other pr_err() in xattr code that can be converted into
hfs_dbg(). Could you please take a look into other ones too?

Thanks,
Slava.

> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  fs/hfsplus/xattr.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
> index c70bb6f494b2..e10e1d8a5862 100644
> --- a/fs/hfsplus/xattr.c
> +++ b/fs/hfsplus/xattr.c
> @@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
>  
>  	if (!strcmp_xattr_finder_info(name)) {
>  		if (flags & XATTR_CREATE) {
> -			pr_err("xattr exists yet\n");
>  			err = -EOPNOTSUPP;
>  			goto end_setxattr;
>  		}
> @@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
>  
>  	if (hfsplus_attr_exists(inode, name)) {
>  		if (flags & XATTR_CREATE) {
> -			pr_err("xattr exists yet\n");
>  			err = -EOPNOTSUPP;
>  			goto end_setxattr;
>  		}


  reply	other threads:[~2026-04-13 17:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-11 12:53 Colin Ian King
2026-04-13 17:12 ` Viacheslav Dubeyko [this message]
2026-04-14 20:19   ` Colin King (gmail)
2026-04-14 21:16     ` Viacheslav Dubeyko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0e9b8218a2daeb65c8481d1f4646f3ca89d713a.camel@redhat.com \
    --to=vdubeyko@redhat.com \
    --cc=colin.i.king@gmail.com \
    --cc=frank.li@vivo.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=slava@dubeyko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®