From: Marcos Del Sol Vives <marcos@orca.pet>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Michael Walle <mwalle@kernel.org>, Lee Jones <lee@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 1/3] gpio: gpio-regmap: add flags to control some behaviour
Date: Thu, 21 Aug 2025 19:14:21 +0200 [thread overview]
Message-ID: <b11fe036-ff94-4226-a5c7-067a195196aa@orca.pet> (raw)
In-Reply-To: <20250821143220.GA672670@bhelgaas>
El 21/08/2025 a las 16:32, Bjorn Helgaas escribió:
> Not my area, but consider making the subject more specific, e.g.,
> "add flag to set direction before value"
>
> On Thu, Aug 21, 2025 at 12:18:57PM +0200, Marcos Del Sol Vives wrote:
>> The Vortex86 family of SoCs need the direction set before the value, else
>> writes to the DATA ports are ignored.
>>
>> This commit adds a new "flags" field plus a flag to change the default
>> behaviour, which is to set first the direction and then the value.
>
> This sounds like the default behavior is to set direction, then value.
> But from the patch, it looks like:
>
> - default: set value, then direction
>
> - with GPIO_REGMAP_DIR_BEFORE_SET: set direction, then value
>
Noted, thanks for the feedback! I've amended the commit and now it reads:
> gpio: gpio-regmap: add flag to set direction before value
>
> When configuring a pin as an output, the gpio-regmap driver by default
> writes first to the the value register, and then configures the direction.
>
> The Vortex86 family of SoCs, however, need the direction set before the
> value, else writes to the data ports are ignored.
>
> This commit adds a new "flags" field plus a flag to reverse that order,
> allowing the direction to be set before the value.
Hope that looks more clear!
Thanks,
Marcos
next prev parent reply other threads:[~2025-08-21 17:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 10:18 [PATCH v3 0/3] Introduce support for Vortex GPIO pins Marcos Del Sol Vives
2025-08-21 10:18 ` [PATCH v3 1/3] gpio: gpio-regmap: add flags to control some behaviour Marcos Del Sol Vives
2025-08-21 14:32 ` Bjorn Helgaas
2025-08-21 17:14 ` Marcos Del Sol Vives [this message]
2025-08-21 16:40 ` Linus Walleij
2025-08-22 7:07 ` Michael Walle
2025-08-22 11:04 ` Marcos Del Sol Vives
2025-08-22 3:27 ` kernel test robot
2025-08-22 11:11 ` Marcos Del Sol Vives
2025-08-21 10:18 ` [PATCH v3 2/3] gpio: vortex: add new GPIO device driver Marcos Del Sol Vives
2025-08-21 16:48 ` Linus Walleij
2025-08-21 17:05 ` Marcos Del Sol Vives
2025-08-22 15:47 ` Bjorn Helgaas
2025-08-22 15:49 ` Bjorn Helgaas
2025-08-22 16:08 ` Marcos Del Sol Vives
2025-08-21 10:18 ` [PATCH v3 3/3] mfd: vortex: implement new driver for Vortex southbridges Marcos Del Sol Vives
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b11fe036-ff94-4226-a5c7-067a195196aa@orca.pet \
--to=marcos@orca.pet \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=helgaas@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mwalle@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®