mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tommi Rantala <tommi.t.rantala@nokia.com>
To: David Miller <davem@davemloft.net>
Cc: jon.maloy@ericsson.com, ying.xue@windriver.com,
	netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()
Date: Tue, 28 Nov 2017 20:16:20 +0200	[thread overview]
Message-ID: <b13bd723-3072-bb9e-c99a-b19141915d86@nokia.com> (raw)
In-Reply-To: <20171128.095837.899409439582426451.davem@davemloft.net>

On 28.11.2017 16:58, David Miller wrote:
> From: Tommi Rantala <tommi.t.rantala@nokia.com>
> Date: Tue, 28 Nov 2017 14:53:15 +0200
> 
>> -
>> -	if (unlikely(msg_user(hdr) == LINK_CONFIG)) {
>> -		err = tipc_udp_rcast_disc(b, skb);
>> -		if (err)
>> -			goto rcu_out;
>> +	} else {
>> +		if (unlikely(b && msg_user(hdr) == LINK_CONFIG))
>> +			tipc_udp_rcast_disc(b, skb);
>> +		kfree_skb(skb);
>>   	}
> 
> Either put the 'err' propagation back or clearly explain in your
> commit log message why this part of the change if absolutely essential
> for this bug fix.
> 
> Thank you.
> 

Thanks for the feedback. I'll post patch v2 soon.

-Tommi

      reply	other threads:[~2017-11-28 18:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 12:53 Tommi Rantala
2017-11-28 13:15 ` Jon Maloy
2017-11-28 14:58 ` David Miller
2017-11-28 18:16   ` Tommi Rantala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b13bd723-3072-bb9e-c99a-b19141915d86@nokia.com \
    --to=tommi.t.rantala@nokia.com \
    --cc=davem@davemloft.net \
    --cc=jon.maloy@ericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=ying.xue@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®