From: David Lechner <david@lechnology.com>
To: Axel Haslam <ahaslam@baylibre.com>,
gregkh@linuxfoundation.org, nsekhar@ti.com, khilman@baylibre.com
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v6 1/5] USB: ohci: da8xx: use ohci priv data instead of globals
Date: Tue, 22 Nov 2016 14:46:49 -0600 [thread overview]
Message-ID: <b15c26d8-d904-dcd4-69bd-d098b89d29c9@lechnology.com> (raw)
In-Reply-To: <20161121163014.28008-2-ahaslam@baylibre.com>
On 11/21/2016 10:30 AM, Axel Haslam wrote:
> Instead of global variables, use the extra_priv_size of
> the ohci driver.
>
> We cannot yet move the ocic mask because this is used on
> the interrupt handler which is registerded through platform
s/registerded/registered/
> data and does not have an hcd pointer. This will be moved
> on a later patch.
>
> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
> ---
Looks good to me (other than the spelling error above).
Tested-by: David Lechner <david@lechnology.com>
next prev parent reply other threads:[~2016-11-22 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 16:30 [PATCH v6 0/5] USB: ohci-da8xx: Add device tree support Axel Haslam
2016-11-21 16:30 ` [PATCH v6 1/5] USB: ohci: da8xx: use ohci priv data instead of globals Axel Haslam
2016-11-22 20:46 ` David Lechner [this message]
2016-11-21 16:30 ` [PATCH v6 2/5] USB: ohci: da8xx: Add wrappers for platform callbacks Axel Haslam
2016-11-21 16:30 ` [PATCH v6 3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS Axel Haslam
2016-11-22 20:37 ` David Lechner
2016-11-22 20:46 ` Axel Haslam
2016-11-22 20:58 ` David Lechner
2016-11-21 16:30 ` [PATCH v6 4/5] USB: ohci: da8xx: Add devicetree bindings Axel Haslam
2016-11-21 16:30 ` [PATCH v6 5/5] USB: ohci: da8xx: Allow probing from DT Axel Haslam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b15c26d8-d904-dcd4-69bd-d098b89d29c9@lechnology.com \
--to=david@lechnology.com \
--cc=ahaslam@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®