From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>, Nishanth Menon <nm@ti.com>,
Tero Kristo <t-kristo@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Lokesh Vutla <lokeshvutla@ti.com>
Cc: Xuefeng Li <lixuefeng@loongson.cn>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type()
Date: Fri, 26 Jun 2020 22:07:27 +0300 [thread overview]
Message-ID: <b1bd0bb8-a1cb-120a-b075-b8fa1886c8a8@ti.com> (raw)
In-Reply-To: <1591437017-5295-1-git-send-email-yangtiezhu@loongson.cn>
On 06/06/2020 12:50, Tiezhu Yang wrote:
> In the function ti_sci_inta_set_type(), the statement "return -EINVAL;"
> out of switch case is dead code, remove it.
>
Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
Right?
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> drivers/irqchip/irq-ti-sci-inta.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
> index 7e3ebf6..c20c9f7 100644
> --- a/drivers/irqchip/irq-ti-sci-inta.c
> +++ b/drivers/irqchip/irq-ti-sci-inta.c
> @@ -433,8 +433,6 @@ static int ti_sci_inta_set_type(struct irq_data *data, unsigned int type)
> default:
> return -EINVAL;
> }
> -
> - return -EINVAL;
> }
>
> static struct irq_chip ti_sci_inta_irq_chip = {
>
For all 3 patches:
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
And you might need re-send it with --cover-letter
--
Best regards,
grygorii
next prev parent reply other threads:[~2020-06-26 19:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 9:50 Tiezhu Yang
2020-06-06 9:50 ` [PATCH 2/3] irqchip/ti-sci-inta: Fix return value about devm_ioremap_resource() Tiezhu Yang
2020-06-06 9:50 ` [PATCH 3/3] irqchip/ti-sci-inta: Fix typo about MODULE_AUTHOR Tiezhu Yang
2020-06-26 19:07 ` Grygorii Strashko [this message]
2020-06-27 11:08 ` [PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type() Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1bd0bb8-a1cb-120a-b075-b8fa1886c8a8@ti.com \
--to=grygorii.strashko@ti.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=lokeshvutla@ti.com \
--cc=maz@kernel.org \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tglx@linutronix.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®