* [PATCH 2/3] irqchip/ti-sci-inta: Fix return value about devm_ioremap_resource()
2020-06-06 9:50 [PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type() Tiezhu Yang
@ 2020-06-06 9:50 ` Tiezhu Yang
2020-06-06 9:50 ` [PATCH 3/3] irqchip/ti-sci-inta: Fix typo about MODULE_AUTHOR Tiezhu Yang
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Tiezhu Yang @ 2020-06-06 9:50 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier, Nishanth Menon,
Tero Kristo, Santosh Shilimkar, Lokesh Vutla
Cc: linux-arm-kernel, linux-kernel, Xuefeng Li
When call function devm_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.
Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-ti-sci-inta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
index c20c9f7..df1f7fe 100644
--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -570,7 +570,7 @@ static int ti_sci_inta_irq_domain_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
inta->base = devm_ioremap_resource(dev, res);
if (IS_ERR(inta->base))
- return -ENODEV;
+ return PTR_ERR(inta->base);
domain = irq_domain_add_linear(dev_of_node(dev),
ti_sci_get_num_resources(inta->vint),
--
2.1.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 3/3] irqchip/ti-sci-inta: Fix typo about MODULE_AUTHOR
2020-06-06 9:50 [PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type() Tiezhu Yang
2020-06-06 9:50 ` [PATCH 2/3] irqchip/ti-sci-inta: Fix return value about devm_ioremap_resource() Tiezhu Yang
@ 2020-06-06 9:50 ` Tiezhu Yang
2020-06-26 19:07 ` [PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type() Grygorii Strashko
2020-06-27 11:08 ` Marc Zyngier
3 siblings, 0 replies; 5+ messages in thread
From: Tiezhu Yang @ 2020-06-06 9:50 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier, Nishanth Menon,
Tero Kristo, Santosh Shilimkar, Lokesh Vutla
Cc: linux-arm-kernel, linux-kernel, Xuefeng Li
It should be "ti.com" instead of "ticom".
Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-ti-sci-inta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
index df1f7fe..ea00d2e 100644
--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -610,6 +610,6 @@ static struct platform_driver ti_sci_inta_irq_domain_driver = {
};
module_platform_driver(ti_sci_inta_irq_domain_driver);
-MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@ticom>");
+MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@ti.com>");
MODULE_DESCRIPTION("K3 Interrupt Aggregator driver over TI SCI protocol");
MODULE_LICENSE("GPL v2");
--
2.1.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type()
2020-06-06 9:50 [PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type() Tiezhu Yang
2020-06-06 9:50 ` [PATCH 2/3] irqchip/ti-sci-inta: Fix return value about devm_ioremap_resource() Tiezhu Yang
2020-06-06 9:50 ` [PATCH 3/3] irqchip/ti-sci-inta: Fix typo about MODULE_AUTHOR Tiezhu Yang
@ 2020-06-26 19:07 ` Grygorii Strashko
2020-06-27 11:08 ` Marc Zyngier
3 siblings, 0 replies; 5+ messages in thread
From: Grygorii Strashko @ 2020-06-26 19:07 UTC (permalink / raw)
To: Tiezhu Yang, Thomas Gleixner, Jason Cooper, Marc Zyngier,
Nishanth Menon, Tero Kristo, Santosh Shilimkar, Lokesh Vutla
Cc: Xuefeng Li, linux-kernel, linux-arm-kernel
On 06/06/2020 12:50, Tiezhu Yang wrote:
> In the function ti_sci_inta_set_type(), the statement "return -EINVAL;"
> out of switch case is dead code, remove it.
>
Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
Right?
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> drivers/irqchip/irq-ti-sci-inta.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
> index 7e3ebf6..c20c9f7 100644
> --- a/drivers/irqchip/irq-ti-sci-inta.c
> +++ b/drivers/irqchip/irq-ti-sci-inta.c
> @@ -433,8 +433,6 @@ static int ti_sci_inta_set_type(struct irq_data *data, unsigned int type)
> default:
> return -EINVAL;
> }
> -
> - return -EINVAL;
> }
>
> static struct irq_chip ti_sci_inta_irq_chip = {
>
For all 3 patches:
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
And you might need re-send it with --cover-letter
--
Best regards,
grygorii
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type()
2020-06-06 9:50 [PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type() Tiezhu Yang
` (2 preceding siblings ...)
2020-06-26 19:07 ` [PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type() Grygorii Strashko
@ 2020-06-27 11:08 ` Marc Zyngier
3 siblings, 0 replies; 5+ messages in thread
From: Marc Zyngier @ 2020-06-27 11:08 UTC (permalink / raw)
To: Jason Cooper, Matthias Brugger, Bartosz Golaszewski,
Thomas Gleixner, Tiezhu Yang, Tero Kristo, Lokesh Vutla,
Nishanth Menon, Santosh Shilimkar
Cc: Andrew Perepech, linux-mediatek, Stephane Le Provost,
linux-arm-kernel, Pedro Tsai, Bartosz Golaszewski, Fabien Parent,
linux-kernel, Xuefeng Li
On Sat, 6 Jun 2020 17:50:15 +0800, Tiezhu Yang wrote:
> In the function ti_sci_inta_set_type(), the statement "return -EINVAL;"
> out of switch case is dead code, remove it.
Applied to irq/irqchip-5.9:
[1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type()
commit: 3d21f0b4126650a92f2df531a5f3a2d27aa9a09f
[2/3] irqchip/ti-sci-inta: Fix return value about devm_ioremap_resource()
commit: 4b127a14cb1385dd355c7673d975258d5d668922
[3/3] irqchip/ti-sci-inta: Fix typo about MODULE_AUTHOR
commit: ef6b0bf43be5c17790a14a8ed806d7d8fe0a25be
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 5+ messages in thread