From: Marek Vasut <marex@denx.de>
To: George McCollister <george.mccollister@gmail.com>,
netdev@vger.kernel.org
Cc: Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Tristram Ha <Tristram.Ha@microchip.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: dsa: microchip: add KSZ9477 I2C driver
Date: Fri, 6 Sep 2019 23:39:47 +0200 [thread overview]
Message-ID: <b1e98d5e-50b7-1f2f-6874-9515fcf2b540@denx.de> (raw)
In-Reply-To: <20190906213054.48908-2-george.mccollister@gmail.com>
On 9/6/19 11:30 PM, George McCollister wrote:
[...]
> --- /dev/null
> +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c
> @@ -0,0 +1,100 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Microchip KSZ9477 series register access through I2C
> + *
> + * Copyright (C) 2018-2019 Microchip Technology Inc.
Doesn't the copyright need update ?
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/regmap.h>
> +#include <linux/i2c.h>
Please keep the headers sorted.
> +#include "ksz_common.h"
> +
> +KSZ_REGMAP_TABLE(ksz9477, not_used, 16, 0, 0);
> +
The rest looks good.
[...]
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-09-06 21:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 21:30 [PATCH net-next 0/3] add ksz9567 with I2C support to ksz9477 driver George McCollister
2019-09-06 21:30 ` [PATCH net-next 1/3] net: dsa: microchip: add KSZ9477 I2C driver George McCollister
2019-09-06 21:39 ` Marek Vasut [this message]
2019-09-09 12:54 ` George McCollister
2019-09-06 21:30 ` [PATCH net-next 2/3] net: dsa: microchip: add ksz9567 to ksz9477 driver George McCollister
2019-09-06 21:41 ` Marek Vasut
2019-09-09 13:33 ` George McCollister
2019-09-06 21:30 ` [PATCH net-next 3/3] net: dsa: microchip: remove NET_DSA_TAG_KSZ_COMMON George McCollister
2019-09-06 21:42 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1e98d5e-50b7-1f2f-6874-9515fcf2b540@denx.de \
--to=marex@denx.de \
--cc=Tristram.Ha@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®