mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Wei Zhang (Stone)" <wei.zhang@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride
Date: Mon, 23 Feb 2026 13:51:22 +0800	[thread overview]
Message-ID: <b1fadee7-74b1-4b66-845c-3a525f259a98@oss.qualcomm.com> (raw)
In-Reply-To: <46d0bc58-2c85-4293-a8ee-480282b80161@oss.qualcomm.com>


On 2/5/2026 5:28 PM, Konrad Dybcio wrote:
> On 1/22/26 6:36 AM, Wei Zhang wrote:
>> Enable WLAN on qcs8300-ride by adding a node for the PMU module
>> of the WCN6855 and assigning its LDO power outputs to the existing
>> WiFi module.
>>
>> On the qcs8300-ride platform, the corresponding firmware and BDF
>> are QCA6698AQ instead of WCN6855, which have been added in the
>> 20250211 release.
>>
>> Signed-off-by: Wei Zhang <wei.zhang@oss.qualcomm.com>
>> ---
> [...]
>
>> +	wlan_en_state: wlan-en-state {
>> +		pins = "gpio54";
>> +		function = "gpio";
>> +		bias-pull-up;
>> +	};
> pull-up sounds odd for an active-high pin
Good point.
GPIO54 is the active‑high WLAN_EN for WCN6855. The pull‑up is intentional to
keep the line stable during early boot and to reduce the risk of a 
low‑to‑high glitch before the PMU driver takes control.
WLAN enable/disable is still explicitly handled by the wcn6855‑pmu 
driver via wlan-enable-gpios.
I can switch this if a different default is preferred.
>
> Konrad

  reply	other threads:[~2026-02-23  5:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22  5:36 Wei Zhang
2026-02-05  2:41 ` Wei Zhang (Stone)
2026-02-05  9:28 ` Konrad Dybcio
2026-02-23  5:51   ` Wei Zhang (Stone) [this message]
2026-02-24 13:34     ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1fadee7-74b1-4b66-845c-3a525f259a98@oss.qualcomm.com \
    --to=wei.zhang@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®