From: David Gow <david@ingeniumdigital.com>
To: Shuvam Pandey <shuvampandey1@gmail.com>,
brendan.higgins@linux.dev, davidgow@google.com
Cc: raemoar63@gmail.com, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kunit: tool: skip stty when stdin is not a tty
Date: Mon, 2 Mar 2026 18:39:22 +0800 [thread overview]
Message-ID: <b1ff54a9-bbf0-4a59-976b-4b5dba21359e@ingeniumdigital.com> (raw)
In-Reply-To: <20260227123136.91086-1-shuvampandey1@gmail.com>
Le 27/02/2026 à 8:31 PM, Shuvam Pandey a écrit :
> run_kernel() cleanup and signal_handler() invoke stty unconditionally.
> When stdin is not a tty (for example in CI or unit tests), this writes
> noise to stderr.
>
> Call stty only when stdin is a tty.
>
> Add regression tests for these paths:
> - run_kernel() with non-tty stdin
> - signal_handler() with non-tty stdin
> - signal_handler() with tty stdin
>
> Signed-off-by: Shuvam Pandey <shuvampandey1@gmail.com>
> ---
Reviewed-by: David Gow <david@davidgow.net>
Cheers,
-- David
prev parent reply other threads:[~2026-03-02 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 12:31 Shuvam Pandey
2026-03-02 10:39 ` David Gow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1ff54a9-bbf0-4a59-976b-4b5dba21359e@ingeniumdigital.com \
--to=david@ingeniumdigital.com \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=raemoar63@gmail.com \
--cc=shuvampandey1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®