* [PATCH] reset: renesas: Check return value of reset_control_deassert()
@ 2021-12-15 10:25 Heiner Kallweit
2021-12-15 10:30 ` Biju Das
2021-12-15 12:18 ` Philipp Zabel
0 siblings, 2 replies; 3+ messages in thread
From: Heiner Kallweit @ 2021-12-15 10:25 UTC (permalink / raw)
To: Philipp Zabel, Biju Das; +Cc: Linux Kernel Mailing List
Deasserting the reset is vital, therefore bail out in case of error.
Suggested-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/reset/reset-rzg2l-usbphy-ctrl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
index 1e8315038..a8dde4606 100644
--- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
+++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
@@ -121,7 +121,9 @@ static int rzg2l_usbphy_ctrl_probe(struct platform_device *pdev)
return dev_err_probe(dev, PTR_ERR(priv->rstc),
"failed to get reset\n");
- reset_control_deassert(priv->rstc);
+ error = reset_control_deassert(priv->rstc);
+ if (error)
+ return error;
priv->rcdev.ops = &rzg2l_usbphy_ctrl_reset_ops;
priv->rcdev.of_reset_n_cells = 1;
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] reset: renesas: Check return value of reset_control_deassert()
2021-12-15 10:25 [PATCH] reset: renesas: Check return value of reset_control_deassert() Heiner Kallweit
@ 2021-12-15 10:30 ` Biju Das
2021-12-15 12:18 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Biju Das @ 2021-12-15 10:30 UTC (permalink / raw)
To: Heiner Kallweit, Philipp Zabel; +Cc: Linux Kernel Mailing List
Hi Heiner,
Thanks for the patch
> Subject: [PATCH] reset: renesas: Check return value of
> reset_control_deassert()
>
> Deasserting the reset is vital, therefore bail out in case of error.
>
> Suggested-by: Biju Das <biju.das.jz@bp.renesas.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Cheers,
Biju
> ---
> drivers/reset/reset-rzg2l-usbphy-ctrl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> index 1e8315038..a8dde4606 100644
> --- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> +++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> @@ -121,7 +121,9 @@ static int rzg2l_usbphy_ctrl_probe(struct
> platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(priv->rstc),
> "failed to get reset\n");
>
> - reset_control_deassert(priv->rstc);
> + error = reset_control_deassert(priv->rstc);
> + if (error)
> + return error;
>
> priv->rcdev.ops = &rzg2l_usbphy_ctrl_reset_ops;
> priv->rcdev.of_reset_n_cells = 1;
> --
> 2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] reset: renesas: Check return value of reset_control_deassert()
2021-12-15 10:25 [PATCH] reset: renesas: Check return value of reset_control_deassert() Heiner Kallweit
2021-12-15 10:30 ` Biju Das
@ 2021-12-15 12:18 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2021-12-15 12:18 UTC (permalink / raw)
To: Heiner Kallweit, Biju Das; +Cc: Linux Kernel Mailing List
On Wed, 2021-12-15 at 11:25 +0100, Heiner Kallweit wrote:
> Deasserting the reset is vital, therefore bail out in case of error.
>
> Suggested-by: Biju Das <biju.das.jz@bp.renesas.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Thank you, applied to reset/next.
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-15 12:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 10:25 [PATCH] reset: renesas: Check return value of reset_control_deassert() Heiner Kallweit
2021-12-15 10:30 ` Biju Das
2021-12-15 12:18 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®