* [PATCH] dt-bindings: display: mediatek: dpi: add power-domains property
@ 2022-07-18 5:22 Allen-KH Cheng
2022-07-18 13:59 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 2+ messages in thread
From: Allen-KH Cheng @ 2022-07-18 5:22 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger, Krzysztof Kozlowski, CK Hu, Jitao shi
Cc: dri-devel, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, hsinyi, fparent,
Project_Global_Chrome_Upstream_Group, Allen-KH Cheng
DPI is part of the display / multimedia block in MediaTek SoCs
and is managed using power controller in some platforms. We add
the power-domains property to the binding documentation.
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index 5bb23e97cf33..9f012afdf19b 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -58,6 +58,9 @@ properties:
Output port node. This port should be connected to the input port of an
attached HDMI, LVDS or DisplayPort encoder chip.
+ power-domains:
+ maxItems: 1
+
required:
- compatible
- reg
@@ -72,11 +75,13 @@ examples:
- |
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/mt8173-clk.h>
+ #include <dt-bindings/power/mt8173-power.h>
dpi0: dpi@1401d000 {
compatible = "mediatek,mt8173-dpi";
reg = <0x1401d000 0x1000>;
interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>;
+ power-domains = <&spm MT8173_POWER_DOMAIN_MM>;
clocks = <&mmsys CLK_MM_DPI_PIXEL>,
<&mmsys CLK_MM_DPI_ENGINE>,
<&apmixedsys CLK_APMIXED_TVDPLL>;
--
2.18.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] dt-bindings: display: mediatek: dpi: add power-domains property
2022-07-18 5:22 [PATCH] dt-bindings: display: mediatek: dpi: add power-domains property Allen-KH Cheng
@ 2022-07-18 13:59 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-18 13:59 UTC (permalink / raw)
To: Allen-KH Cheng, Rob Herring, Matthias Brugger,
Krzysztof Kozlowski, CK Hu, Jitao shi
Cc: dri-devel, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, hsinyi, fparent,
Project_Global_Chrome_Upstream_Group
Il 18/07/22 07:22, Allen-KH Cheng ha scritto:
> DPI is part of the display / multimedia block in MediaTek SoCs
> and is managed using power controller in some platforms. We add
> the power-domains property to the binding documentation.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
For the contents of this commit:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
...but I'm not sure whether this one requires a Fixes tag (because, effectively,
the DPI hardware *requires* that power domain to get up) - and if it does,
which commit to reference: the first commit for this file is a TXT->schema
conversion, but the TXT didn't have power-domains as well.
Regards,
Angelo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-18 13:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-18 5:22 [PATCH] dt-bindings: display: mediatek: dpi: add power-domains property Allen-KH Cheng
2022-07-18 13:59 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®