From: przemo@firszt.eu
To: "Jeremy Fitzhardinge" <jeremy@goop.org>
Cc: "Jiri Kosina" <jkosina@suse.cz>,
"Przemo Firszt" <przemo@firszt.eu>,
chris@cnpbagwell.com, pinglinux@gmail.com,
linuxwacom-devel@lists.sourceforge.net,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: wacom: Fix invalid power_supply_powers calls
Date: Mon, 6 Feb 2012 17:44:17 -0000 [thread overview]
Message-ID: <b24d411c05c013317690ef4cec330c71.squirrel@webmail.firszt.eu> (raw)
In-Reply-To: <4F300F2C.9030308@goop.org>
> On 02/06/2012 04:42 AM, Jiri Kosina wrote:
>> On Mon, 6 Feb 2012, przemo@firszt.eu wrote:
>>
>>>> Hmm, seems valid. How did you notice? Have you seen crashes because of
>>>> wild pointers?
>>> Hi Jiri,
>>> Yes, the driver was unusable - 100% crashes during connection.
>> Okay, I thought that'd be the case.
>
> Very sorry about that. I don't have a device to test with, so I should
> have reviewed the code extra carefully.
>
> Does the same bug apply to the Wii changes, which were of the same form?
>
Hi Jeremy,
The wii code looks the same, so probably it's affected as well. Can you
make a patch?
power_supply_powers call in wiimote driver:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/hid/hid-wiimote-core.c#l1229
regards,
Przemo Firszt
next prev parent reply other threads:[~2012-02-06 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-05 22:35 Przemo Firszt
2012-02-06 12:27 ` Jiri Kosina
2012-02-06 12:34 ` przemo
2012-02-06 12:42 ` Jiri Kosina
2012-02-06 17:34 ` Jeremy Fitzhardinge
2012-02-06 17:44 ` przemo [this message]
2012-02-07 12:43 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b24d411c05c013317690ef4cec330c71.squirrel@webmail.firszt.eu \
--to=przemo@firszt.eu \
--cc=chris@cnpbagwell.com \
--cc=jeremy@goop.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxwacom-devel@lists.sourceforge.net \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®