* Re: [PATCH] lightnvm: pblk: fix use-after-free bug
2018-12-22 18:30 ` [PATCH] lightnvm: pblk: fix use-after-free bug Matias Bjørling
@ 2018-12-22 19:01 ` Gustavo A. R. Silva
2018-12-22 21:45 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-12-22 19:01 UTC (permalink / raw)
To: Matias Bjørling, Igor Konopko, Jens Axboe; +Cc: linux-block, linux-kernel
On 12/22/18 12:30 PM, Matias Bjørling wrote:
> On 12/22/18 8:39 AM, Gustavo A. R. Silva wrote:
>> Remove one of the calls to function bio_put(), so *bio* is only
>> freed once.
>>
>> Notice that bio is being dereferenced in bio_put(), hence leading to
>> a use-after-free bug once *bio* has already been freed.
>>
>> Addresses-Coverity-ID: 1475952 ("Use after free")
>> Fixes: 55d8ec35398e ("lightnvm: pblk: support packed metadata")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/lightnvm/pblk-recovery.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/lightnvm/pblk-recovery.c
>> b/drivers/lightnvm/pblk-recovery.c
>> index 3fcf062d752c..5ee20da7bdb3 100644
>> --- a/drivers/lightnvm/pblk-recovery.c
>> +++ b/drivers/lightnvm/pblk-recovery.c
>> @@ -418,7 +418,6 @@ static int pblk_recov_scan_oob(struct pblk *pblk,
>> struct pblk_line *line,
>> if (ret) {
>> pblk_err(pblk, "I/O submission failed: %d\n", ret);
>> bio_put(bio);
>> - bio_put(bio);
>> return ret;
>> }
>>
>
> Thanks Gustavo. I missed that one.
>
> Jens, if possible could you please pick this up?
>
> Happy holidays!
>
Glad to help. :)
Happy holidays everybody.
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] lightnvm: pblk: fix use-after-free bug
2018-12-22 18:30 ` [PATCH] lightnvm: pblk: fix use-after-free bug Matias Bjørling
2018-12-22 19:01 ` Gustavo A. R. Silva
@ 2018-12-22 21:45 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2018-12-22 21:45 UTC (permalink / raw)
To: Matias Bjørling, Gustavo A. R. Silva, Igor Konopko
Cc: linux-block, linux-kernel
On 12/22/18 11:30 AM, Matias Bjørling wrote:
> On 12/22/18 8:39 AM, Gustavo A. R. Silva wrote:
>> Remove one of the calls to function bio_put(), so *bio* is only
>> freed once.
>>
>> Notice that bio is being dereferenced in bio_put(), hence leading to
>> a use-after-free bug once *bio* has already been freed.
>>
>> Addresses-Coverity-ID: 1475952 ("Use after free")
>> Fixes: 55d8ec35398e ("lightnvm: pblk: support packed metadata")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/lightnvm/pblk-recovery.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/lightnvm/pblk-recovery.c b/drivers/lightnvm/pblk-recovery.c
>> index 3fcf062d752c..5ee20da7bdb3 100644
>> --- a/drivers/lightnvm/pblk-recovery.c
>> +++ b/drivers/lightnvm/pblk-recovery.c
>> @@ -418,7 +418,6 @@ static int pblk_recov_scan_oob(struct pblk *pblk, struct pblk_line *line,
>> if (ret) {
>> pblk_err(pblk, "I/O submission failed: %d\n", ret);
>> bio_put(bio);
>> - bio_put(bio);
>> return ret;
>> }
>>
>>
>
> Thanks Gustavo. I missed that one.
>
> Jens, if possible could you please pick this up?
Yep, added for the later pull.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread