[PATCH] checkpatch: Do not hardcode perl path

[PATCH] checkpatch: Do not hardcode perl path

[Jagannadha Sutradharudu Teki]

checkpatch.pl requires perl v5.10.0 to run but it
doesn't require to place in /usr/bin/perl
Use env to ensure that the interpreter used is the
first one on environment's $PATH on system with
several versions of perl installed.

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
---
 scripts/checkpatch.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9c98100..241bb11 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1,10 +1,11 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
 # (c) 2001, Dave Jones. (the file handling bit)
 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
 # Licensed under the terms of the GNU GPL License version 2
 
+use warnings;
 use strict;
 use POSIX;
 
-- 
1.8.3

Re: [PATCH] checkpatch: Do not hardcode perl path

[Joe Perches]

On Thu, 2013-12-05 at 16:53 +0530, Jagannadha Sutradharudu Teki wrote:
> checkpatch.pl requires perl v5.10.0 to run but it
> doesn't require to place in /usr/bin/perl
> Use env to ensure that the interpreter used is the
> first one on environment's $PATH on system with
> several versions of perl installed.

I don't have an opinion on this patch.

RE: [PATCH] checkpatch: Do not hardcode perl path

[Jagannadha Sutradharudu Teki]

> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Friday, December 06, 2013 1:22 AM
> To: Jagannadha Sutradharudu Teki
> Cc: linux-kernel@vger.kernel.org; Andy Whitcroft; Jagannadha Sutradharudu
> Teki
> Subject: Re: [PATCH] checkpatch: Do not hardcode perl path
>
> On Thu, 2013-12-05 at 16:53 +0530, Jagannadha Sutradharudu Teki wrote:
> > checkpatch.pl requires perl v5.10.0 to run but it doesn't require to
> > place in /usr/bin/perl Use env to ensure that the interpreter used is
> > the first one on environment's $PATH on system with several versions
> > of perl installed.
>
> I don't have an opinion on this patch.

fyi: I have some notes here - this change will took the perl bin(if user explicitly use perl instead of from /usr/bin/perl) from bashrc instead of taking /usr/bin/perl all the time.

Jagan.



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.