mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Support RAA229639 and RAA229640
@ 2026-09-21  7:16 Colin Huang
  2026-09-21  7:16 ` [PATCH v3 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas " Colin Huang
  2026-09-21  7:16 ` [PATCH v3 2/2] hwmon: (pmbus/isl68137): " Colin Huang
  0 siblings, 2 replies; 8+ messages in thread
From: Colin Huang @ 2026-09-21  7:16 UTC (permalink / raw)
  To: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Geert Uytterhoeven, Magnus Damm, Grant Peltier
  Cc: linux-hwmon, devicetree, linux-kernel, linux-renesas-soc,
	colin.huang2, Colin Huang

Signed-off-by: Colin Huang <u8813345@gmail.com>
---
Changes in v3:
- Updated the OF match entries for renesas,raa229639 and renesas,raa229640 to use 
  raa_dmpvr2_2rail_nontc instead of raa_dmpvr2_2rail.
- Compatible with existing 2-rail non-TC controllers and use renesas,raa228244 
  as fallback compatible.
- Link to v2: https://lore.kernel.org/r/20260908-add-raa229639-and-raa229640-v2-0-83c75b61139d@gmail.com

Changes in v2:
- Clarify why fallback compatibles are not added in the DT binding.
- Reword driver commit message to avoid implying DT-level compatibility.
- Link to v1: https://lore.kernel.org/r/20260907-add-raa229639-and-raa229640-v1-0-8f7218cba85d@gmail.com

---
Colin Huang (2):
      dt-bindings: hwmon: pmbus: isl68137: Add Renesas RAA229639 and RAA229640
      hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640

 Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 2 ++
 drivers/hwmon/pmbus/isl68137.c                                   | 4 ++++
 2 files changed, 6 insertions(+)
---
base-commit: f4c3b88983f342d6614cb11b53a0640ec8bc8fd2
change-id: 20260902-add-raa229639-and-raa229640-c72fa121df82

Best regards,
-- 
Colin Huang <u8813345@gmail.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v3 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas RAA229639 and RAA229640
  2026-09-21  7:16 [PATCH v3 0/2] Support RAA229639 and RAA229640 Colin Huang
@ 2026-09-21  7:16 ` Colin Huang
  2026-09-25 15:11   ` Krzysztof Kozlowski
  2026-09-25 16:28   ` Guenter Roeck
  2026-09-21  7:16 ` [PATCH v3 2/2] hwmon: (pmbus/isl68137): " Colin Huang
  1 sibling, 2 replies; 8+ messages in thread
From: Colin Huang @ 2026-09-21  7:16 UTC (permalink / raw)
  To: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Geert Uytterhoeven, Magnus Damm, Grant Peltier
  Cc: linux-hwmon, devicetree, linux-kernel, linux-renesas-soc,
	colin.huang2, Colin Huang

Add Device Tree compatible strings for Renesas RAA229639 and
RAA229640 PMBus devices.

They are compatible with existing 2-rail non-TC controllers
and use renesas,raa228244 as fallback compatible

Signed-off-by: Colin Huang <u8813345@gmail.com>
---
 Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
index 8216cdf758d8..a604b67b764d 100644
--- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
@@ -65,6 +65,8 @@ properties:
           - enum:
               - renesas,raa228942
               - renesas,raa228943
+              - renesas,raa229639
+              - renesas,raa229640
           - const: renesas,raa228244
 
   reg:

-- 
2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v3 2/2] hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640
  2026-09-21  7:16 [PATCH v3 0/2] Support RAA229639 and RAA229640 Colin Huang
  2026-09-21  7:16 ` [PATCH v3 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas " Colin Huang
@ 2026-09-21  7:16 ` Colin Huang
  2026-09-25 13:06   ` Krzysztof Kozlowski
  2026-09-25 16:28   ` Guenter Roeck
  1 sibling, 2 replies; 8+ messages in thread
From: Colin Huang @ 2026-09-21  7:16 UTC (permalink / raw)
  To: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Geert Uytterhoeven, Magnus Damm, Grant Peltier
  Cc: linux-hwmon, devicetree, linux-kernel, linux-renesas-soc,
	colin.huang2, Colin Huang

Add support for the Renesas RAA229639 and RAA229640 PMBus
voltage regulator devices.

Both devices are supported by the existing raa_dmpvr2_2rail_nontc
driver variant, so no functional changes are required beyond
adding the corresponding device IDs and OF match entries.

Signed-off-by: Colin Huang <u8813345@gmail.com>
---
 drivers/hwmon/pmbus/isl68137.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
index 2f7f825bfb69..15b4e3f15f11 100644
--- a/drivers/hwmon/pmbus/isl68137.c
+++ b/drivers/hwmon/pmbus/isl68137.c
@@ -456,6 +456,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
 	{ .name = "raa229004", .driver_data = raa_dmpvr2_2rail },
 	{ .name = "raa229141", .driver_data = raa_dmpvr2_2rail_pmbus },
 	{ .name = "raa229621", .driver_data = raa_dmpvr2_2rail },
+	{ .name = "raa229639", .driver_data = raa_dmpvr2_2rail_nontc },
+	{ .name = "raa229640", .driver_data = raa_dmpvr2_2rail_nontc },
 	{ }
 };
 
@@ -506,6 +508,8 @@ static const struct of_device_id isl68137_of_match[] = {
 	{ .compatible = "renesas,raa229001", .data = (void *)raa_dmpvr2_2rail },
 	{ .compatible = "renesas,raa229004", .data = (void *)raa_dmpvr2_2rail },
 	{ .compatible = "renesas,raa229621", .data = (void *)raa_dmpvr2_2rail },
+	{ .compatible = "renesas,raa229639", .data = (void *)raa_dmpvr2_2rail_nontc },
+	{ .compatible = "renesas,raa229640", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ },
 };
 

-- 
2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v3 2/2] hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640
  2026-09-21  7:16 ` [PATCH v3 2/2] hwmon: (pmbus/isl68137): " Colin Huang
@ 2026-09-25 13:06   ` Krzysztof Kozlowski
  2026-09-25 13:53     ` Guenter Roeck
  2026-09-25 16:28   ` Guenter Roeck
  1 sibling, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-25 13:06 UTC (permalink / raw)
  To: Colin Huang
  Cc: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Geert Uytterhoeven, Magnus Damm, Grant Peltier, linux-hwmon,
	devicetree, linux-kernel, linux-renesas-soc, colin.huang2

On Mon, Sep 21, 2026 at 03:16:36PM +0800, Colin Huang wrote:
> Add support for the Renesas RAA229639 and RAA229640 PMBus
> voltage regulator devices.
> 
> Both devices are supported by the existing raa_dmpvr2_2rail_nontc
> driver variant, so no functional changes are required beyond
> adding the corresponding device IDs and OF match entries.
> 
> Signed-off-by: Colin Huang <u8813345@gmail.com>
> ---
>  drivers/hwmon/pmbus/isl68137.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
> index 2f7f825bfb69..15b4e3f15f11 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -456,6 +456,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
>  	{ .name = "raa229004", .driver_data = raa_dmpvr2_2rail },
>  	{ .name = "raa229141", .driver_data = raa_dmpvr2_2rail_pmbus },
>  	{ .name = "raa229621", .driver_data = raa_dmpvr2_2rail },
> +	{ .name = "raa229639", .driver_data = raa_dmpvr2_2rail_nontc },
> +	{ .name = "raa229640", .driver_data = raa_dmpvr2_2rail_nontc },

The entire point of fallback is to avoid this change. Why do you need
this?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v3 2/2] hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640
  2026-09-25 13:06   ` Krzysztof Kozlowski
@ 2026-09-25 13:53     ` Guenter Roeck
  0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2026-09-25 13:53 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Colin Huang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Geert Uytterhoeven, Magnus Damm, Grant Peltier, linux-hwmon,
	devicetree, linux-kernel, linux-renesas-soc, colin.huang2

On Fri, Sep 25, 2026 at 03:06:51PM +0200, Krzysztof Kozlowski wrote:
> On Mon, Sep 21, 2026 at 03:16:36PM +0800, Colin Huang wrote:
> > Add support for the Renesas RAA229639 and RAA229640 PMBus
> > voltage regulator devices.
> > 
> > Both devices are supported by the existing raa_dmpvr2_2rail_nontc
> > driver variant, so no functional changes are required beyond
> > adding the corresponding device IDs and OF match entries.
> > 
> > Signed-off-by: Colin Huang <u8813345@gmail.com>
> > ---
> >  drivers/hwmon/pmbus/isl68137.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
> > index 2f7f825bfb69..15b4e3f15f11 100644
> > --- a/drivers/hwmon/pmbus/isl68137.c
> > +++ b/drivers/hwmon/pmbus/isl68137.c
> > @@ -456,6 +456,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
> >  	{ .name = "raa229004", .driver_data = raa_dmpvr2_2rail },
> >  	{ .name = "raa229141", .driver_data = raa_dmpvr2_2rail_pmbus },
> >  	{ .name = "raa229621", .driver_data = raa_dmpvr2_2rail },
> > +	{ .name = "raa229639", .driver_data = raa_dmpvr2_2rail_nontc },
> > +	{ .name = "raa229640", .driver_data = raa_dmpvr2_2rail_nontc },
> 
> The entire point of fallback is to avoid this change. Why do you need
> this?
> 

I personally like to have it for this driver because it makes it easy to
track which device require which configuration without having to track down
devicetree fallbacks.

Guenter

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas RAA229639 and RAA229640
  2026-09-21  7:16 ` [PATCH v3 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas " Colin Huang
@ 2026-09-25 15:11   ` Krzysztof Kozlowski
  2026-09-25 16:28   ` Guenter Roeck
  1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-25 15:11 UTC (permalink / raw)
  To: Colin Huang, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Geert Uytterhoeven, Magnus Damm, Grant Peltier
  Cc: linux-hwmon, devicetree, linux-kernel, linux-renesas-soc, colin.huang2

On 21/09/2026 09:16, Colin Huang wrote:
> Add Device Tree compatible strings for Renesas RAA229639 and
> RAA229640 PMBus devices.
> 
> They are compatible with existing 2-rail non-TC controllers
> and use renesas,raa228244 as fallback compatible
> 
> Signed-off-by: Colin Huang <u8813345@gmail.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas RAA229639 and RAA229640
  2026-09-21  7:16 ` [PATCH v3 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas " Colin Huang
  2026-09-25 15:11   ` Krzysztof Kozlowski
@ 2026-09-25 16:28   ` Guenter Roeck
  1 sibling, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2026-09-25 16:28 UTC (permalink / raw)
  To: Colin Huang
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Geert Uytterhoeven, Magnus Damm, Grant Peltier, linux-hwmon,
	devicetree, linux-kernel, linux-renesas-soc, colin.huang2

On Mon, Sep 21, 2026 at 03:16:35PM +0800, Colin Huang wrote:
> Add Device Tree compatible strings for Renesas RAA229639 and
> RAA229640 PMBus devices.
> 
> They are compatible with existing 2-rail non-TC controllers
> and use renesas,raa228244 as fallback compatible
> 
> Signed-off-by: Colin Huang <u8813345@gmail.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v3 2/2] hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640
  2026-09-21  7:16 ` [PATCH v3 2/2] hwmon: (pmbus/isl68137): " Colin Huang
  2026-09-25 13:06   ` Krzysztof Kozlowski
@ 2026-09-25 16:28   ` Guenter Roeck
  1 sibling, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2026-09-25 16:28 UTC (permalink / raw)
  To: Colin Huang
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Geert Uytterhoeven, Magnus Damm, Grant Peltier, linux-hwmon,
	devicetree, linux-kernel, linux-renesas-soc, colin.huang2

On Mon, Sep 21, 2026 at 03:16:36PM +0800, Colin Huang wrote:
> Add support for the Renesas RAA229639 and RAA229640 PMBus
> voltage regulator devices.
> 
> Both devices are supported by the existing raa_dmpvr2_2rail_nontc
> driver variant, so no functional changes are required beyond
> adding the corresponding device IDs and OF match entries.
> 
> Signed-off-by: Colin Huang <u8813345@gmail.com>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-09-25 16:28 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-21  7:16 [PATCH v3 0/2] Support RAA229639 and RAA229640 Colin Huang
2026-09-21  7:16 ` [PATCH v3 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas " Colin Huang
2026-09-25 15:11   ` Krzysztof Kozlowski
2026-09-25 16:28   ` Guenter Roeck
2026-09-21  7:16 ` [PATCH v3 2/2] hwmon: (pmbus/isl68137): " Colin Huang
2026-09-25 13:06   ` Krzysztof Kozlowski
2026-09-25 13:53     ` Guenter Roeck
2026-09-25 16:28   ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®