From: Jason Yan <yanaijie@huawei.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
<f.fainelli@gmail.com>, <tglx@linutronix.de>,
<jason@lakedaemon.net>, <maz@kernel.org>, <justinpopo6@gmail.com>,
<bcm-kernel-feedback-list@broadcom.com>,
<linux-mips@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static
Date: Fri, 17 Apr 2020 18:56:43 +0800 [thread overview]
Message-ID: <b2f6f8cd-557c-3978-f176-e615cba8b458@huawei.com> (raw)
In-Reply-To: <ecb3e3e1-7761-faa7-10fa-67da69604306@cogentembedded.com>
在 2020/4/17 18:26, Sergei Shtylyov 写道:
> Hello!
>
> On 17.04.2020 10:40, Jason Yan wrote:
>
>> Fix the following sparse warning:
>>
>> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
>> 'bcm7038_l1_of_init' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>> drivers/irqchip/irq-bcm7038-l1.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c
>> b/drivers/irqchip/irq-bcm7038-l1.c
>> index eb9bce93cd05..fd7c537fb42a 100644
>> --- a/drivers/irqchip/irq-bcm7038-l1.c
>> +++ b/drivers/irqchip/irq-bcm7038-l1.c
>> @@ -416,7 +416,7 @@ static const struct irq_domain_ops
>> bcm7038_l1_domain_ops = {
>> .map = bcm7038_l1_map,
>> };
>> -int __init bcm7038_l1_of_init(struct device_node *dn,
>> +static int __init bcm7038_l1_of_init(struct device_node *dn,
>> struct device_node *parent)
>
> Reindent the above line please, it should start under *struct* on
> the 1st line.
OK, will cook a new one.
>
> [...]
>
> MBR, Sergei
>
> .
next prev parent reply other threads:[~2020-04-17 10:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 7:40 Jason Yan
2020-04-17 9:56 ` [tip: irq/urgent] irqchip/irq-bcm7038-l1: Make " tip-bot2 for Jason Yan
2020-04-17 10:26 ` [PATCH] irqchip/irq-bcm7038-l1: make " Sergei Shtylyov
2020-04-17 10:56 ` Jason Yan [this message]
2020-04-17 11:07 ` Marc Zyngier
2020-04-17 11:10 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2f6f8cd-557c-3978-f176-e615cba8b458@huawei.com \
--to=yanaijie@huawei.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=hulkci@huawei.com \
--cc=jason@lakedaemon.net \
--cc=justinpopo6@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®