mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] watchdog: bd96081: Fix a spelling mistake
@ 2025-11-14  2:05 Chu Guangqing
  2025-11-14  2:35 ` Guenter Roeck
  2025-11-14  9:17 ` Matti Vaittinen
  0 siblings, 2 replies; 3+ messages in thread
From: Chu Guangqing @ 2025-11-14  2:05 UTC (permalink / raw)
  To: mazziesaccount, wim, linux; +Cc: linux-watchdog, linux-kernel, Chu Guangqing

The spelling of the word "initializate" is incorrect; the correct spelling is
"initialize".

Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>
---
 drivers/watchdog/bd96801_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/bd96801_wdt.c b/drivers/watchdog/bd96801_wdt.c
index 12b74fd2bc05..43ec23c53e62 100644
--- a/drivers/watchdog/bd96801_wdt.c
+++ b/drivers/watchdog/bd96801_wdt.c
@@ -370,7 +370,7 @@ static int bd96801_wdt_probe(struct platform_device *pdev)
 
 		set_bit(WDOG_HW_RUNNING, &w->wdt.status);
 	} else {
-		/* If WDG is not running so we will initializate it */
+		/* If WDG is not running so we will initialize it */
 		ret = init_wdg_hw(w);
 		if (ret)
 			return ret;
-- 
2.43.7


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] watchdog: bd96081: Fix a spelling mistake
  2025-11-14  2:05 [PATCH v2] watchdog: bd96081: Fix a spelling mistake Chu Guangqing
@ 2025-11-14  2:35 ` Guenter Roeck
  2025-11-14  9:17 ` Matti Vaittinen
  1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2025-11-14  2:35 UTC (permalink / raw)
  To: Chu Guangqing, mazziesaccount, wim; +Cc: linux-watchdog, linux-kernel

On 11/13/25 18:05, Chu Guangqing wrote:
> The spelling of the word "initializate" is incorrect; the correct spelling is
> "initialize".
> 
> Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>
> ---

Change log goes here, even for trivial patches.

>   drivers/watchdog/bd96801_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/bd96801_wdt.c b/drivers/watchdog/bd96801_wdt.c
> index 12b74fd2bc05..43ec23c53e62 100644
> --- a/drivers/watchdog/bd96801_wdt.c
> +++ b/drivers/watchdog/bd96801_wdt.c
> @@ -370,7 +370,7 @@ static int bd96801_wdt_probe(struct platform_device *pdev)
>   
>   		set_bit(WDOG_HW_RUNNING, &w->wdt.status);
>   	} else {
> -		/* If WDG is not running so we will initializate it */
> +		/* If WDG is not running so we will initialize it */
>   		ret = init_wdg_hw(w);
>   		if (ret)
>   			return ret;


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] watchdog: bd96081: Fix a spelling mistake
  2025-11-14  2:05 [PATCH v2] watchdog: bd96081: Fix a spelling mistake Chu Guangqing
  2025-11-14  2:35 ` Guenter Roeck
@ 2025-11-14  9:17 ` Matti Vaittinen
  1 sibling, 0 replies; 3+ messages in thread
From: Matti Vaittinen @ 2025-11-14  9:17 UTC (permalink / raw)
  To: Chu Guangqing, wim, linux; +Cc: linux-watchdog, linux-kernel

Hi Chu!

Thanks for the fix!

Hm. I suppose I missed the v1. I agree with Guenter that a change log 
would be nice. Then I knew what was in v1 without looking for it.



On 14/11/2025 04:05, Chu Guangqing wrote:
> The spelling of the word "initializate" is incorrect; the correct spelling is
> "initialize".
> 
> Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>
> ---
>   drivers/watchdog/bd96801_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/bd96801_wdt.c b/drivers/watchdog/bd96801_wdt.c
> index 12b74fd2bc05..43ec23c53e62 100644
> --- a/drivers/watchdog/bd96801_wdt.c
> +++ b/drivers/watchdog/bd96801_wdt.c
> @@ -370,7 +370,7 @@ static int bd96801_wdt_probe(struct platform_device *pdev)
>   
>   		set_bit(WDOG_HW_RUNNING, &w->wdt.status);
>   	} else {
> -		/* If WDG is not running so we will initializate it */
> +		/* If WDG is not running so we will initialize it */

I think it would be even better if the 'so' was dropped. And, as a 
matter of fact, I am not sure the comment serves any real purpose here. 
The code pretty much says it already. So, I am OK with either dropping 
the 'so' as well, or the whole comment.

With that:
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>

>   		ret = init_wdg_hw(w);
>   		if (ret)
>   			return ret;
Yours,
	-- Matti

---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-14  9:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-14  2:05 [PATCH v2] watchdog: bd96081: Fix a spelling mistake Chu Guangqing
2025-11-14  2:35 ` Guenter Roeck
2025-11-14  9:17 ` Matti Vaittinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®